Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

KOGITO-2466: BDD tests: Update Port in Ingress for KogitoRuntime #403

Merged
merged 1 commit into from Jun 25, 2020
Merged

KOGITO-2466: BDD tests: Update Port in Ingress for KogitoRuntime #403

merged 1 commit into from Jun 25, 2020

Conversation

Sgitario
Copy link
Contributor

@Sgitario Sgitario commented Jun 25, 2020 •
edited

JIRA: https://issues.redhat.com/browse/KOGITO-2466
Description:

  • Use the port settings from the kogito service specification.

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Pull Request title is properly formatted: [KOGITO-XYZ] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Your feature/bug fix has a unit test that verifies it
  • You've tested the new feature/bug fix in an actual OpenShift cluster

@Sgitario
Copy link
Contributor Author

I ran the runtime scenario successfully in Openshift and local Kubernetes.

@Sgitario Sgitario added bdd-tests 🧪 PR is related to the BDD test framework ready 🚀 PR is ready to be merged needs review 🔍 Pull Request that needs reviewers and removed ready 🚀 PR is ready to be merged labels Jun 25, 2020
@ricardozanini ricardozanini added this to the v0.12.0 milestone Jun 25, 2020
sutaakar
sutaakar approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@sutaakar sutaakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@spolti spolti merged commit 5d13089 into apache:master Jun 25, 2020
@ricardozanini ricardozanini added ready 🚀 PR is ready to be merged and removed needs review 🔍 Pull Request that needs reviewers labels Jun 25, 2020
@Sgitario Sgitario deleted the KOGITO-2466 branch June 26, 2020 05:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ricardozanini ricardozanini ricardozanini approved these changes

@sutaakar sutaakar sutaakar approved these changes

@radtriste radtriste Awaiting requested review from radtriste

Assignees
No one assigned
Labels
bdd-tests 🧪 PR is related to the BDD test framework ready 🚀 PR is ready to be merged
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Sgitario @ricardozanini @sutaakar @spolti