Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

[KOGITO-2290][KOGITO-2291] Setup stages for release #420

Merged
merged 3 commits into from
Aug 10, 2020
Merged

[KOGITO-2290][KOGITO-2291] Setup stages for release #420

merged 3 commits into from
Aug 10, 2020

Conversation

radtriste
Copy link
Contributor

@radtriste radtriste commented Jul 3, 2020 •
edited

https://issues.redhat.com/browse/KOGITO-2290
https://issues.redhat.com/browse/KOGITO-2291

Include also https://issues.redhat.com/browse/KOGITO-1013 from @Kevin-Mok

Many thanks for submiting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Pull Request title is properly formatted: [KOGITO-XYZ] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Your feature/bug fix has a unit test that verifies it
  • You've tested the new feature/bug fix in an actual OpenShift cluster

@radtriste radtriste added the WIP 👷‍♂️ Pull Request is on work in progress label Jul 3, 2020
@radtriste radtriste changed the title [KOGITO-2290/2291] Setup stages for release [KOGITO-2290][KOGITO-2291] Setup stages for release Jul 3, 2020
Kevin-Mok
Kevin-Mok suggested changes Jul 7, 2020
View reviewed changes
Jenkinsfile.deploy Outdated Show resolved Hide resolved
Jenkinsfile.deploy Outdated Show resolved Hide resolved
Jenkinsfile.deploy Outdated Show resolved Hide resolved
@ricardozanini ricardozanini added this to the v0.13.0 milestone Jul 7, 2020
@radtriste radtriste force-pushed the release-pipeline branch 5 times, most recently from 305e56d to 4435613 Compare July 8, 2020 11:54
@Kevin-Mok Kevin-Mok mentioned this pull request Jul 9, 2020
Merged
7 tasks
Kevin-Mok
Kevin-Mok suggested changes Jul 9, 2020
View reviewed changes
Jenkinsfile.deploy Outdated Show resolved Hide resolved
Jenkinsfile.deploy Outdated Show resolved Hide resolved
Jenkinsfile.promote Show resolved Hide resolved
Jenkinsfile.promote Outdated Show resolved Hide resolved
Jenkinsfile.promote Outdated Show resolved Hide resolved
Kevin-Mok
Kevin-Mok suggested changes Jul 10, 2020
View reviewed changes
Jenkinsfile.promote Outdated Show resolved Hide resolved
Jenkinsfile.deploy Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 10, 2020 •
edited

Codecov Report

Merging #420 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #420   +/-   ##
=======================================
  Coverage   42.01%   42.01%           
=======================================
  Files         169      169           
  Lines        9012     9012           
=======================================
  Hits         3786     3786           
  Misses       4812     4812           
  Partials      414      414
Flag Coverage Δ
#cli 54.97% <ø> (ø)
#operator 38.57% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/apis/app/v1alpha1/kogitoapp_types.go 7.40% <ø> (ø)
pkg/apis/app/v1alpha1/zz_generated.openapi.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b0be93...ece0fb9. Read the comment docs.

@radtriste radtriste force-pushed the release-pipeline branch 5 times, most recently from b0f4e70 to 9f9e9ef Compare July 15, 2020 17:04
Kevin-Mok
Kevin-Mok suggested changes Jul 16, 2020
View reviewed changes
Jenkinsfile.promote Outdated Show resolved Hide resolved
Kevin-Mok
Kevin-Mok reviewed Jul 16, 2020
View reviewed changes
Jenkinsfile.promote Outdated Show resolved Hide resolved
@radtriste radtriste force-pushed the release-pipeline branch 7 times, most recently from e3d8e5f to 27dfcbe Compare July 20, 2020 13:14
@kie-ci-bot kie-ci-bot bot added the needs review 🔍 Pull Request that needs reviewers label Aug 4, 2020
@radtriste radtriste force-pushed the release-pipeline branch 3 times, most recently from bbc699b to c1f5aa2 Compare August 6, 2020 13:05
@radtriste radtriste marked this pull request as ready for review August 6, 2020 13:37
@radtriste radtriste requested review from Kevin-Mok and removed request for spolti August 6, 2020 13:37
@radtriste radtriste added CI/CD ➿ Pull Request related to Continous Integration/ Deployment and removed WIP 👷‍♂️ Pull Request is on work in progress labels Aug 6, 2020
ricardozanini
ricardozanini approved these changes Aug 6, 2020
View reviewed changes
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!!

Kevin-Mok
Kevin-Mok approved these changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@Kevin-Mok Kevin-Mok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Jenkinsfile.promote Outdated Show resolved Hide resolved
@ricardozanini ricardozanini added ready 🚀 PR is ready to be merged and removed needs review 🔍 Pull Request that needs reviewers labels Aug 7, 2020
@radtriste radtriste mentioned this pull request Aug 7, 2020
Merged
@spolti
Copy link
Member

spolti commented Aug 7, 2020

@radtriste is this ready to merge?

@radtriste
Copy link
Contributor Author

running final checks on that one. Will merge it once it is ok.

@radtriste radtriste merged commit 9043fd9 into apache:master Aug 10, 2020
@radtriste radtriste deleted the release-pipeline branch August 12, 2020 10:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ricardozanini ricardozanini ricardozanini approved these changes

@spolti spolti spolti approved these changes

@Kevin-Mok Kevin-Mok Kevin-Mok approved these changes

@Kaitou786 Kaitou786 Kaitou786 approved these changes

Assignees
No one assigned
Labels
CI/CD ➿ Pull Request related to Continous Integration/ Deployment ready 🚀 PR is ready to be merged
Projects
None yet
Milestone
v0.14.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@radtriste @spolti @ricardozanini @Kevin-Mok @Kaitou786