-
Notifications
You must be signed in to change notification settings - Fork 79
[KOGITO-2916] CLI auto-completion for fish shell #480
Conversation
Codecov Report
@@ Coverage Diff @@
## master #480 +/- ##
==========================================
- Coverage 43.77% 42.06% -1.72%
==========================================
Files 144 169 +25
Lines 8692 9036 +344
==========================================
- Hits 3805 3801 -4
- Misses 4462 4821 +359
+ Partials 425 414 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't test every instruction permutation for each shell (bash, zsh, fish) on each os (linux, mac), but it looks like you've covered everything. Your instruction updates are probably "more correct" than what I had in there before, especially for zsh... Next up, powershell? 😜
@errantepiphany I just copied the instructions from the Cobra docs. I figured they'd be more up-to-date/accurate, and I might as well update everything if I'm adding in the fish documentation.
That would go against my values. 😛 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome! Many thanks @Kevin-Mok ;)
@radtriste since you're handling the release, I believe we are ready to start merging 0.14, right? I'll leave this up to you, tho. |
@ricardozanini release branch is already created for the release so anything can be merged safely to master |
See: https://issues.redhat.com/browse/KOGITO-2916
After running
kogito completion fish > ~/.config/fish/completions/kogito.fish
, the auto-completion forfish
works and looks like such:I also updated the long description for
kogito completion --help
to match Cobra's latest long description.Requirements
Many thanks for submiting your Pull Request ❤️!
Please make sure that your PR meets the following requirements:
[KOGITO-XYZ] Subject