Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

[KOGITO-2916] CLI auto-completion for fish shell #480

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

Kevin-Mok
Copy link
Contributor

See: https://issues.redhat.com/browse/KOGITO-2916

After running kogito completion fish > ~/.config/fish/completions/kogito.fish, the auto-completion for fish works and looks like such:
screenshot-2020-07-30_10:16:26

I also updated the long description for kogito completion --help to match Cobra's latest long description.

Requirements

Many thanks for submiting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Pull Request title is properly formatted: [KOGITO-XYZ] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Your feature/bug fix has a unit test that verifies it
  • You've tested the new feature/bug fix in an actual OpenShift cluster

@codecov
Copy link

codecov bot commented Jul 30, 2020

Codecov Report

Merging #480 into master will decrease coverage by 1.71%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #480      +/-   ##
==========================================
- Coverage   43.77%   42.06%   -1.72%     
==========================================
  Files         144      169      +25     
  Lines        8692     9036     +344     
==========================================
- Hits         3805     3801       -4     
- Misses       4462     4821     +359     
+ Partials      425      414      -11     
Flag Coverage Δ
#cli 54.97% <36.70%> (-13.12%) ⬇️
#operator 38.65% <81.25%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/kogito/command/flag/artifact_flag.go 0.00% <0.00%> (ø)
cmd/kogito/command/flag/build_flag.go 0.00% <0.00%> (ø)
cmd/kogito/command/flag/env_flag.go 0.00% <0.00%> (ø)
cmd/kogito/command/flag/gitsource_flag.go 0.00% <0.00%> (ø)
cmd/kogito/command/flag/image_flag.go 0.00% <0.00%> (ø)
cmd/kogito/command/flag/install_flag.go 0.00% <0.00%> (ø)
cmd/kogito/command/flag/kafka_flag.go 0.00% <0.00%> (ø)
cmd/kogito/command/flag/operator_flag.go 0.00% <ø> (ø)
cmd/kogito/command/flag/podresource_flag.go 0.00% <0.00%> (ø)
cmd/kogito/command/flag/runtime_flag.go 0.00% <0.00%> (ø)
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 308c010...7d0b02e. Read the comment docs.

Copy link
Contributor

@errantepiphany errantepiphany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test every instruction permutation for each shell (bash, zsh, fish) on each os (linux, mac), but it looks like you've covered everything. Your instruction updates are probably "more correct" than what I had in there before, especially for zsh... Next up, powershell? 😜

@Kevin-Mok
Copy link
Contributor Author

Kevin-Mok commented Jul 30, 2020

@errantepiphany I just copied the instructions from the Cobra docs. I figured they'd be more up-to-date/accurate, and I might as well update everything if I'm adding in the fish documentation.

Next up, powershell? 😜

That would go against my values. 😛

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Many thanks @Kevin-Mok ;)

@ricardozanini ricardozanini added this to the v0.14.0 milestone Jul 30, 2020
@ricardozanini ricardozanini added the ready 🚀 PR is ready to be merged label Jul 30, 2020
@ricardozanini
Copy link
Member

@radtriste since you're handling the release, I believe we are ready to start merging 0.14, right? I'll leave this up to you, tho.

@radtriste
Copy link
Contributor

@ricardozanini release branch is already created for the release so anything can be merged safely to master

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready 🚀 PR is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants