Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

KOGITO-3333: Refactor Jobs Service test with keycloak #557

Merged
merged 1 commit into from
Sep 17, 2020
Merged

KOGITO-3333: Refactor Jobs Service test with keycloak #557

merged 1 commit into from
Sep 17, 2020

Conversation

Sgitario
Copy link
Contributor

@Sgitario Sgitario commented Sep 14, 2020 •
edited

JIRA: https://issues.redhat.com/browse/KOGITO-3333
Description: Rewriting scenario to check whether the route is forbidden.

Many thanks for submiting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

  • You have read the contributors' guide
  • Pull Request title is properly formatted: [KOGITO-XYZ] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Your feature/bug fix has a unit test that verifies it
  • You've tested the new feature/bug fix in an actual OpenShift cluster

@kie-ci-bot kie-ci-bot bot added bdd-tests 🧪 PR is related to the BDD test framework needs review 🔍 Pull Request that needs reviewers labels Sep 14, 2020
@Sgitario Sgitario added the on hold ✋ Pull Request is waiting for other dependencies label Sep 14, 2020
@ricardozanini ricardozanini added this to the v0.16.0 milestone Sep 14, 2020
@kie-ci-bot
Copy link

kie-ci-bot bot commented Sep 15, 2020

Change detected in the PR, requesting reviews and running pipeline(if required) again

@Sgitario Sgitario changed the title KOGITO-3333: Cucumber Tests: Fix "Install Kogito Jobs Service with Ke… KOGITO-3333: Refactor Jobs Service test with keycloak Sep 15, 2020
@Sgitario Sgitario removed the on hold ✋ Pull Request is waiting for other dependencies label Sep 15, 2020
@Sgitario
Copy link
Contributor Author

It depends on https://github.com/kiegroup/kogito-apps/pull/457

@Sgitario
Copy link
Contributor Author

I've tested this test using a custom Jobs Service with the changes in https://github.com/kiegroup/kogito-apps/pull/457.

@ricardozanini
Copy link
Member

Many thanks @Sgitario. This PR will fix the Keycloak errors we are seeing in the PR checks?

@Sgitario
Copy link
Contributor Author

Many thanks @Sgitario. This PR will fix the Keycloak errors we are seeing in the PR checks?

Nope, those errors will be fixed as part of kiegroup/kogito-apps#457.

@ricardozanini ricardozanini added ready 🚀 PR is ready to be merged on hold ✋ Pull Request is waiting for other dependencies and removed needs review 🔍 Pull Request that needs reviewers ready 🚀 PR is ready to be merged labels Sep 15, 2020
@ricardozanini
Copy link
Member

@Sgitario once https://github.com/kiegroup/kogito-apps/pull/457 got merged, could you please set the label ready? Then I'll merge it.

@ricardozanini ricardozanini added ready 🚀 PR is ready to be merged and removed on hold ✋ Pull Request is waiting for other dependencies labels Sep 17, 2020
@ricardozanini
Copy link
Member

@Sgitario merge?

@Sgitario
Copy link
Contributor Author

@Sgitario merge?

Yes

@spolti spolti merged commit f9e9e1c into apache:master Sep 17, 2020
@Sgitario Sgitario deleted the KOGITO-3333 branch September 18, 2020 05:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ricardozanini ricardozanini ricardozanini approved these changes

@sutaakar sutaakar sutaakar approved these changes

@radtriste radtriste Awaiting requested review from radtriste

Assignees
No one assigned
Labels
bdd-tests 🧪 PR is related to the BDD test framework ready 🚀 PR is ready to be merged
Projects
None yet
Milestone
v0.16.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Sgitario @ricardozanini @sutaakar @spolti