Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

[KOGITO-271] Upgrade to SDK 0.10.0 #60

Merged
merged 1 commit into from
Sep 17, 2019

Conversation

ricardozanini
Copy link
Member

@ricardozanini ricardozanini commented Sep 16, 2019

See: https://issues.jboss.org/browse/KOGITO-271

In this PR:

  1. Simple upgrade to Operator SDK 0.10.0
  2. Since this is a major change that can mess things up, we fixed the e2e tests to make sure everything is working cluster wide. It's darn simple, but should be improved in the future (See https://issues.jboss.org/browse/KOGITO-130)

Many thanks for submiting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Pull Request title is properly formatted: [KOGITO-XYZ] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Your feature/bug fix has a unit test that verifies it
  • You've tested the new feature/bug fix in an actual OpenShift cluster

Copy link
Contributor

@sutaakar sutaakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@xieshenzh xieshenzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ricardozanini . Since v0.10.0 supports configuring timestamp format for logging, I think we should make the timestamp more readable.

README.md Outdated Show resolved Hide resolved
@ricardozanini
Copy link
Member Author

Thanks, @ricardozanini . Since v0.10.0 supports configuring timestamp format for logging, I think we should make the timestamp more readable.

Hmm... the logs showed with the DEBUG flag turned on, you mean? Otherwise those logs are meant to be consumed by the OpenShift log stack, which means that his format should be valid there. Correct? If not, we can add this change for sure.

@ricardozanini
Copy link
Member Author

@xiezhang7 I added the iso format to our inner log, but this change on 0.10.0 it's not meant to be used outside their CLI, as far as I understood that PR you mentioned.

Anyway, now the log is much more readable:

{"level":"info","T":"2019-09-17T20:07:14.689Z","logger":"controller_kogitoapp","msg":"Checking if build for 'example-quarkus' is finished"}
{"level":"info","T":"2019-09-17T20:07:14.801Z","logger":"controller_kogitoapp","msg":"Reconcile for 'example-quarkus' successfully finished"}
{"level":"info","T":"2019-09-17T20:07:14.801Z","logger":"controller_kogitoapp","msg":"Reconciling KogitoApp"}
{"level":"info","T":"2019-09-17T20:07:14.801Z","logger":"controller_kogitoapp","msg":"Checking if all resources for 'karina-test' are created"}
{"level":"info","T":"2019-09-17T20:07:14.815Z","logger":"controller_kogitoapp","msg":"Checking if build for 'karina-test' is finished"}
{"level":"info","T":"2019-09-17T20:07:14.927Z","logger":"controller_kogitoapp","msg":"Reconcile for 'karina-test' successfully finished"}
{"level":"info","T":"2019-09-17T20:07:14.928Z","logger":"controller_kogitoapp","msg":"Reconciling KogitoApp"}
{"level":"info","T":"2019-09-17T20:07:14.928Z","logger":"controller_kogitoapp","msg":"Checking if all resources for 'jbpm-quarkus-example' are created"}
{"level":"info","T":"2019-09-17T20:07:14.939Z","logger":"controller_kogitoapp","msg":"Checking if build for 'jbpm-quarkus-example' is finished"}
{"level":"info","T":"2019-09-17T20:07:15.053Z","logger":"controller_kogitoapp","msg":"Reconcile for 'jbpm-quarkus-example' successfully finished"}

Could you please review?

@xieshenzh
Copy link
Contributor

@xiezhang7 I added the iso format to our inner log, but this change on 0.10.0 it's not meant to be used outside their CLI, as far as I understood that PR you mentioned.

Anyway, now the log is much more readable

Could you please review?

Thanks, @ricardozanini . It looks great.

@ricardozanini ricardozanini added ready 🚀 PR is ready to be merged and removed needs review 🔍 Pull Request that needs reviewers labels Sep 17, 2019
@ricardozanini ricardozanini merged commit 1f7f3b5 into apache:master Sep 17, 2019
@ricardozanini ricardozanini deleted the kogito-271 branch October 24, 2019 15:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready 🚀 PR is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants