[KOGITO-3568] - Remove spec.httpPort attribute from Operator and HTTP… #630

Kaitou786 · 2020-10-28T09:54:20Z

…_PORT env var from Kogito images

See: https://issues.redhat.com/browse/KOGITO-3568
Signed-off-by: Tarun Khandelwal tarkhand@redhat.com

Many thanks for submiting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

You have read the contributors' guide
Pull Request title is properly formatted: [KOGITO-XYZ] Subject
Pull Request contains link to the JIRA issue
Pull Request contains description of the issue
Pull Request does not include fixes for issues other than the main ticket
Your feature/bug fix has a unit test that verifies it
You've tested the new feature/bug fix in an actual OpenShift cluster

Kaitou786 · 2020-10-28T09:54:41Z

/jenkins test

codecov · 2020-10-28T09:57:49Z

Codecov Report

Merging #630 into master will decrease coverage by 4.30%.
The diff coverage is 57.61%.

@@            Coverage Diff             @@
##           master     #630      +/-   ##
==========================================
- Coverage   42.01%   37.70%   -4.31%     
==========================================
  Files         169      146      -23     
  Lines        9012     6224    -2788     
==========================================
- Hits         3786     2347    -1439     
+ Misses       4812     3502    -1310     
+ Partials      414      375      -39

Flag	Coverage Δ
#cli	`54.17% <57.61%> (-0.81%)`	⬇️
#operator	`33.07% <ø> (-5.50%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
cmd/kogito/command/service/build_service.go	`0.00% <0.00%> (ø)`
cmd/kogito/command/service/runtime_service.go	`0.00% <0.00%> (ø)`
cmd/kogito/command/shared/default_services.go	`0.00% <0.00%> (ø)`
cmd/kogito/command/shared/install_services.go	`0.00% <0.00%> (ø)`
cmd/kogito/command/shared/resource_checks.go	`63.29% <0.00%> (-4.53%)`	⬇️
pkg/apis/app/v1alpha1/conditions.go	`93.10% <ø> (+3.62%)`	⬆️
pkg/apis/app/v1alpha1/kogitobuild_types.go	`14.28% <ø> (-85.72%)`	⬇️
pkg/apis/app/v1alpha1/kogitoinfra_types.go	`100.00% <ø> (ø)`
pkg/apis/app/v1alpha1/kogitoruntime_types.go	`10.00% <ø> (-2.50%)`	⬇️
pkg/apis/app/v1alpha1/kogitoservices_types.go	`0.00% <ø> (ø)`
... and 201 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 734652e...d123ec4. Read the comment docs.

Kaitou786 · 2020-10-28T10:31:42Z

/jenkins test

Sgitario

There is a BDD scenario to cover the functionality that has been removed: update_httpport.feature. Therefore, this feature needs to be removed as well.

kie-ci-bot · 2020-10-28T11:09:14Z

Change detected in the PR, requesting reviews and running pipeline(if required) again

Kaitou786 · 2020-10-28T11:10:00Z

There is a BDD scenario to cover the functionality that has been removed: update_httpport.feature. Therefore, this feature needs to be removed as well.

Thanks, removed the file :)

Kaitou786 · 2020-10-28T11:18:50Z

/jenkins test

ricardozanini

I like to see the old code going away. Nice job! You've been doing a great job removing things from the operator. :)

ricardozanini · 2020-10-28T13:17:18Z

@Kaitou786 please update the RELEASE_NOTES.md file. Maybe we should add this rule to the bot?

kie-ci-bot · 2020-10-28T13:42:31Z

Change detected in the PR, requesting reviews and running pipeline(if required) again

kie-ci-bot · 2020-10-28T13:44:29Z

Change detected in the PR, requesting reviews and running pipeline(if required) again

Kaitou786 · 2020-10-28T13:46:00Z

@Kaitou786 please update the RELEASE_NOTES.md file. Maybe we should add this rule to the bot?

Done, for the bot what kind of rule do we want, every PR which have a milestone should be added to RELEASE_NOTES.md?

vaibhavjainwiz

Remove HTTPPort from following locations :

https://github.com/Kaitou786/kogito-cloud-operator/blob/f66b32fbf3b72b1a19b81c266024d8417b8a136c/cmd/kogito/command/flag/install_flag.go#L37
https://github.com/Kaitou786/kogito-cloud-operator/blob/0576a63b824a4e86fe24733951c3879ce225e6e1/cmd/kogito/command/install/supportingservices_test.go#L63
https://github.com/Kaitou786/kogito-cloud-operator/blob/5882b1477d6ab59b833eac700ad0234f1049d976/examples/data-index.yaml#L35
https://github.com/Kaitou786/kogito-cloud-operator/blob/5882b1477d6ab59b833eac700ad0234f1049d976/examples/explainability.yaml#L25
https://github.com/Kaitou786/kogito-cloud-operator/blob/5882b1477d6ab59b833eac700ad0234f1049d976/examples/trusty.yaml#L36
Remove setHTTPPortInEnvVar function. No more required.
https://github.com/Kaitou786/kogito-cloud-operator/blob/0576a63b824a4e86fe24733951c3879ce225e6e1/pkg/infrastructure/services/deployment.go#L90
No need to pass HTTPPort in function args. We can directly initialize it with framework.DefaultExposedPort
https://github.com/Kaitou786/kogito-cloud-operator/blob/154a2d0a1c7af1ab3eabe894d03016268815551f/pkg/infrastructure/services/probe.go#L95
Also need to remove HTTPPort from kogito-images as well

kie-ci-bot · 2020-10-28T14:49:21Z

Change detected in the PR, requesting reviews and running pipeline(if required) again

kie-ci-bot · 2020-10-28T14:50:47Z

Change detected in the PR, requesting reviews and running pipeline(if required) again

Kaitou786 · 2020-10-28T14:52:07Z

@vaibhavjainwiz Thanks for noticing these :), I added all your comments can you take a second look :)

Kaitou786 · 2020-10-28T14:53:22Z

/jenkins test

vaibhavjainwiz

LGTM

Kaitou786 · 2020-10-28T16:10:30Z

/jenkins test

Kaitou786 · 2020-10-29T08:56:45Z

/jenkins test

ricardozanini · 2020-10-29T10:55:43Z

@sutaakar do you want to take a look before I merge this one?

…_PORT env var from Kogito images See: https://issues.redhat.com/browse/KOGITO-3568 Signed-off-by: Tarun Khandelwal <tarkhand@redhat.com>

kie-ci-bot · 2020-10-29T11:57:52Z

Change detected in the PR, requesting reviews and running pipeline(if required) again

kie-ci-bot · 2020-10-29T12:10:12Z

Change detected in the PR, requesting reviews and running pipeline(if required) again

Kaitou786 · 2020-10-29T12:23:21Z

/jenkins test

sutaakar

Looks good to me

kie-ci-bot bot added the WIP 👷‍♂️ Pull Request is on work in progress label Oct 28, 2020

Kaitou786 marked this pull request as ready for review October 28, 2020 10:59

kie-ci-bot bot removed the WIP 👷‍♂️ Pull Request is on work in progress label Oct 28, 2020

kie-ci-bot bot requested review from radtriste, ricardozanini, Sgitario, spolti and sutaakar October 28, 2020 10:59

kie-ci-bot bot added bdd-tests 🧪 PR is related to the BDD test framework cli 💻 Pull Request related to cli code base needs review 🔍 Pull Request that needs reviewers operator ☁️ Pull Request related to kogito-operator code base labels Oct 28, 2020

Kaitou786 requested review from vaibhavjainwiz and removed request for Sgitario October 28, 2020 10:59

Sgitario approved these changes Oct 28, 2020

View reviewed changes

Sgitario suggested changes Oct 28, 2020

View reviewed changes

Kaitou786 requested a review from Sgitario October 28, 2020 11:11

radtriste approved these changes Oct 28, 2020

View reviewed changes

Sgitario approved these changes Oct 28, 2020

View reviewed changes

ricardozanini approved these changes Oct 28, 2020

View reviewed changes

ricardozanini added this to the v1.0.0 milestone Oct 28, 2020

Kaitou786 force-pushed the KOGITO-3568 branch from 3c96464 to b671bab Compare October 28, 2020 13:44

vaibhavjainwiz suggested changes Oct 28, 2020

View reviewed changes

Kaitou786 requested a review from vaibhavjainwiz October 28, 2020 14:51

vaibhavjainwiz approved these changes Oct 28, 2020

View reviewed changes

spolti approved these changes Oct 28, 2020

View reviewed changes

Tarun Khandelwal added 5 commits October 29, 2020 17:27

[KOGITO-3568] - Remove spec.httpPort attribute from Operator and HTTP…

c83b668

…_PORT env var from Kogito images See: https://issues.redhat.com/browse/KOGITO-3568 Signed-off-by: Tarun Khandelwal <tarkhand@redhat.com>

Deleted update_httpport.feature file

0e82d5b

enter details in RELEASE_NOTES.md

0782a49

review comments

4212af9

review comments

ae82e22

Kaitou786 force-pushed the KOGITO-3568 branch from d52b016 to ae82e22 Compare October 29, 2020 11:57

rebase issue

d123ec4

sutaakar approved these changes Oct 29, 2020

View reviewed changes

ricardozanini added ready 🚀 PR is ready to be merged and removed needs review 🔍 Pull Request that needs reviewers labels Oct 29, 2020

ricardozanini merged commit b681c89 into apache:master Oct 29, 2020

Kaitou786 deleted the KOGITO-3568 branch October 29, 2020 14:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[KOGITO-3568] - Remove spec.httpPort attribute from Operator and HTTP… #630

[KOGITO-3568] - Remove spec.httpPort attribute from Operator and HTTP… #630

Kaitou786 commented Oct 28, 2020 •

edited

Kaitou786 commented Oct 28, 2020

codecov bot commented Oct 28, 2020 •

edited

Kaitou786 commented Oct 28, 2020

Sgitario left a comment

kie-ci-bot bot commented Oct 28, 2020

Kaitou786 commented Oct 28, 2020

Kaitou786 commented Oct 28, 2020

ricardozanini left a comment •

edited

ricardozanini commented Oct 28, 2020

kie-ci-bot bot commented Oct 28, 2020

kie-ci-bot bot commented Oct 28, 2020

Kaitou786 commented Oct 28, 2020

vaibhavjainwiz left a comment

kie-ci-bot bot commented Oct 28, 2020

kie-ci-bot bot commented Oct 28, 2020

Kaitou786 commented Oct 28, 2020 •

edited

Kaitou786 commented Oct 28, 2020

vaibhavjainwiz left a comment

Kaitou786 commented Oct 28, 2020

Kaitou786 commented Oct 29, 2020

ricardozanini commented Oct 29, 2020

kie-ci-bot bot commented Oct 29, 2020

kie-ci-bot bot commented Oct 29, 2020

Kaitou786 commented Oct 29, 2020

sutaakar left a comment

[KOGITO-3568] - Remove spec.httpPort attribute from Operator and HTTP… #630

[KOGITO-3568] - Remove spec.httpPort attribute from Operator and HTTP… #630

Conversation

Kaitou786 commented Oct 28, 2020 • edited

Kaitou786 commented Oct 28, 2020

codecov bot commented Oct 28, 2020 • edited

Codecov Report

Kaitou786 commented Oct 28, 2020

Sgitario left a comment

Choose a reason for hiding this comment

kie-ci-bot bot commented Oct 28, 2020

Kaitou786 commented Oct 28, 2020

Kaitou786 commented Oct 28, 2020

ricardozanini left a comment • edited

Choose a reason for hiding this comment

ricardozanini commented Oct 28, 2020

kie-ci-bot bot commented Oct 28, 2020

kie-ci-bot bot commented Oct 28, 2020

Kaitou786 commented Oct 28, 2020

vaibhavjainwiz left a comment

Choose a reason for hiding this comment

kie-ci-bot bot commented Oct 28, 2020

kie-ci-bot bot commented Oct 28, 2020

Kaitou786 commented Oct 28, 2020 • edited

Kaitou786 commented Oct 28, 2020

vaibhavjainwiz left a comment

Choose a reason for hiding this comment

Kaitou786 commented Oct 28, 2020

Kaitou786 commented Oct 29, 2020

ricardozanini commented Oct 29, 2020

kie-ci-bot bot commented Oct 29, 2020

kie-ci-bot bot commented Oct 29, 2020

Kaitou786 commented Oct 29, 2020

sutaakar left a comment

Choose a reason for hiding this comment

Kaitou786 commented Oct 28, 2020 •

edited

codecov bot commented Oct 28, 2020 •

edited

ricardozanini left a comment •

edited

Kaitou786 commented Oct 28, 2020 •

edited