[KOGITO-3708] - Decreasing the amount of reconciliation loops for Kog…

[ricardozanini]

…itoInfra

See: https://issues.redhat.com/browse/KOGITO-3708

This is what looks like a non-OK infra resource:

oc get kogitoinfra
NAME                      RESOURCE NAME   KIND         API VERSION         STATUS   REASON
kogito-infinispan-infra                   Infinispan   infinispan.org/v1   False    ResourceAPINotFound

Here's the interval between reconciliations:

2020-10-28T17:05:36.365-0300	INFO	kogitoinfra_controller	Successfully Update Kogito Infra status
...
2020-10-28T17:06:06.338-0300	INFO	kogitoinfra_controller	Reconciling KogitoInfra for kogito-infinispan-infra in kogito-3708

30 seconds :)

Signed-off-by: Ricardo Zanini zanini@redhat.com

Many thanks for submiting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

• You have read the contributors' guide
• Pull Request title is properly formatted: [KOGITO-XYZ] Subject
• Pull Request contains link to the JIRA issue
• Pull Request contains description of the issue
• Pull Request does not include fixes for issues other than the main ticket
• Your feature/bug fix has a unit test that verifies it
• You've tested the new feature/bug fix in an actual OpenShift cluster

[codecov]

Codecov Report

Merging #633 into master will decrease coverage by 4.15%.
The diff coverage is 57.61%.

@@            Coverage Diff             @@
##           master     #633      +/-   ##
==========================================
- Coverage   42.01%   37.85%   -4.16%     
==========================================
  Files         169      146      -23     
  Lines        9012     6271    -2741     
==========================================
- Hits         3786     2374    -1412     
+ Misses       4812     3523    -1289     
+ Partials      414      374      -40     

Flag	Coverage Δ
#cli	54.17% <57.61%> (-0.81%)	⬇️
#operator	33.31% <ø> (-5.27%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
cmd/kogito/command/service/build_service.go	0.00% <0.00%> (ø)
cmd/kogito/command/service/runtime_service.go	0.00% <0.00%> (ø)
cmd/kogito/command/shared/default_services.go	0.00% <0.00%> (ø)
cmd/kogito/command/shared/install_services.go	0.00% <0.00%> (ø)
cmd/kogito/command/shared/resource_checks.go	63.29% <0.00%> (-4.53%)	⬇️
pkg/apis/app/v1alpha1/conditions.go	93.10% <ø> (+3.62%)	⬆️
pkg/apis/app/v1alpha1/kogitobuild_types.go	14.28% <ø> (-85.72%)	⬇️
pkg/apis/app/v1alpha1/kogitoinfra_types.go	100.00% <ø> (ø)
pkg/apis/app/v1alpha1/kogitoruntime_types.go	10.00% <ø> (-2.50%)	⬇️
pkg/apis/app/v1alpha1/kogitoservices_types.go	0.00% <ø> (ø)
... and 200 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c369846...cb3f76b. Read the comment docs.

[ricardozanini]

/jenkins test

[r00ta]

Hi @ricardozanini , the BDD tests are failing on every PRs (on a data-index test). So I think this is not related to my changes. Can we move forward with this?

[ricardozanini]

@r00ta I'll investigate with @sutaakar why it's failing, and we will get back to the feature.

[sutaakar]

The Data index tag was changed yesterday, images were built few hours ago. Retriggering the tests:
/jenkins test

[radtriste]

small suggestion. otherwise looks good

[sutaakar]

Looks good to me, thanks.
Tested and works as expected.

[ricardozanini]

@spolti @vaibhavjainwiz could you please take a look? I'll rebase the RELEASE_NOTES doc but this should not affect this PR anyhow.

[kie-ci-bot]

Change detected in the PR, requesting reviews and running pipeline(if required) again

[ricardozanini]

/jenkins test

[kie-ci-bot]

Change detected in the PR, requesting reviews and running pipeline(if required) again

[ricardozanini]

/jenkins test

[spolti]

ooops, thanks for fixing it :D

[spolti]

/jenkins test

[ricardozanini]

Was working this morning..

/jenkins test

EDIT: no clue...

https://image-registry.openshift-image-registry.svc:5000/v2/openshift/process-timer-quarkus-default-nightly/blobs/uploads/2c6ca2bf-5671-4f34-8c3d-1147fc7d2252?_state=qpwyx_tyOskJ2HrhiqL2Q1ftZou1G0LHgISX8yTPc0p7Ik5hbWUiOiJvcGVuc2hpZnQvcHJvY2Vzcy10aW1lci1xdWFya3VzLWRlZmF1bHQtbmlnaHRseSIsIlVVSUQiOiIyYzZjYTJiZi01NjcxLTRmMzQtOGMzZC0xMTQ3ZmM3ZDIyNTIiLCJPZmZzZXQiOjAsIlN0YXJ0ZWRBdCI6IjIwMjAtMTAtMjlUMTU6MzA6MzAuNTM3NTQ5NTE4WiJ9: open /var/lib/containers/storage/overlay/541ae15c25dcc1247cd4de7982a3f51cce8c603b4151c007409e2cde6c2abc48/merged/home/kogito/bin/lib/ch.obermuhlner.big-math-2.0.1.jar: no such file or directory\n"}
{"level":"error","T":"2020-10-29T15:30:30.970Z","logger":"jenkins-cucumber-1eb5","msg":"Error in step 'Local example service \"process-timer-quarkus\" is built by Maven using profile \"default\" and deployed to runtime registry': exit status 1"}
{"level":"warn","T":"2020-10-29T15:30:30.975Z","logger":"jenkins-cucumber-1eb5","msg":"Namespace not found for operation"}
{"level":"error","T":"2020-10-29T15:30:30.978Z","logger":"jenkins-cucumber-1eb5","msg":"Error in scenario 'Build process-timer-quarkus images': exit status 1"}
{"level":"info","T":"2020-10-29T15:30:30.978Z","logger":"jenkins-cucumber-1eb5","msg":"Scenario duration: 55.309352868s"}
{"level":"warn","T":"2020-10-29T15:30:31.199Z","logger":"jenkins-cucumber-1eb5","msg":"Namespace not found for operation"}

[sutaakar]

This time the test failed on Strimzi operator installation:

2020-10-29 16:03:10  | 2020-10-29 16:03:10  |        | strimzi-cluster-operator.v0.20.0.164282089666bcd5      | -     | -                                       | Normal  | RequirementsNotMet   | -       | -           | -         | one or more requirements couldn't be found                                                                                                        | 

Not sure why, locally it seems that Strimzi is installed successfully.
/jenkins test

[ricardozanini]

/jenkins test

[ricardozanini]

/jenkins test

[kie-ci-bot]

Change detected in the PR, requesting reviews and running pipeline(if required) again

[ricardozanini]

/jenkins test

[kie-ci-bot]

Change detected in the PR, requesting reviews and running pipeline(if required) again

[ricardozanini]

Data Index test still hangs in the Strimzi operator.

[ricardozanini]

This lint error is super weird, locally I can't see anything, my tree is clean. Maybe because we are removing and creating the file every time? This shouldn't be a problem since the file is the same!

❯ rm ./kogito-operator.yaml
❯ git status -s
 D kogito-operator.yaml
❯ for yaml in deploy/crds/*_crd.yaml; do cat "${yaml}" >> ./kogito-operator.yaml; printf "\n---\n" >> ./kogito-operator.yaml; done
❯ git status -s
 M kogito-operator.yaml
❯ for yaml in deploy/*.yaml; do cat "${yaml}" >> ./kogito-operator.yaml; printf "\n---\n" >> ./kogito-operator.yaml; done
❯ git status -s

NOTHING!

[kie-ci-bot]

Change detected in the PR, requesting reviews and running pipeline(if required) again

[radtriste]

\jenkins test

[radtriste]

Having the same problem there: #639

[radtriste]

/jenkins test

[ricardozanini]

@sutaakar as per our conversation, I'm merging this one.