Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

[KOGITO-4241] Setup godog 0.11 #732

Merged
merged 1 commit into from Jan 25, 2021
Merged

Conversation

radtriste
Copy link
Contributor

@radtriste radtriste commented Jan 21, 2021

https://issues.redhat.com/browse/KOGITO-4241

Many thanks for submitting your Pull Request ❤️!

Please make sure your PR meets the following requirements:

  • You have read the contributors' guide
  • Pull Request title is properly formatted: [KOGITO-XYZ] Subject
  • Pull Request contains a link to the JIRA issue
  • Pull Request contains a description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Your feature/bug fix has a unit test that verifies it
  • You've tested the new feature/bug fix in an actual OpenShift cluster
  • You've added a RELEASE_NOTES.md entry regarding this change

@kie-ci-bot kie-ci-bot bot added the WIP 👷‍♂️ Pull Request is on work in progress label Jan 21, 2021
@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #732 (68508e5) into master (0b5d664) will increase coverage by 8.41%.
The diff coverage is 33.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #732      +/-   ##
==========================================
+ Coverage   38.67%   47.08%   +8.41%     
==========================================
  Files         151      142       -9     
  Lines        6516     5235    -1281     
==========================================
- Hits         2520     2465      -55     
+ Misses       3601     2389    -1212     
+ Partials      395      381      -14     
Flag Coverage Δ
cli 53.13% <33.33%> (-1.18%) ⬇️
controllers 45.87% <33.39%> (?)
operator 44.84% <ø> (+10.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/kogito/command/converter/artifact_converter.go 100.00% <ø> (ø)
...ito/command/converter/binarybuildtype_converter.go 100.00% <ø> (ø)
...md/kogito/command/converter/gitsource_converter.go 100.00% <ø> (ø)
...ogito/command/converter/infraresource_converter.go 100.00% <ø> (ø)
...ito/command/converter/kogitobuildtype_converter.go 77.77% <ø> (ø)
...d/kogito/command/converter/monitoring_converter.go 100.00% <ø> (ø)
...d/kogito/command/converter/properties_converter.go 0.00% <0.00%> (ø)
.../kogito/command/converter/runtimetype_converter.go 80.00% <ø> (ø)
...ogito/command/converter/webhooksecret_converter.go 75.00% <ø> (ø)
cmd/kogito/command/install/factory.go 100.00% <ø> (ø)
... and 82 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c813a5...a8b3554. Read the comment docs.

@radtriste radtriste changed the title Godog 0.11 [KOGITO-4241] Setup godog 0.11 Jan 21, 2021
@radtriste
Copy link
Contributor Author

/jenkins test

@radtriste radtriste marked this pull request as ready for review January 22, 2021 18:52
@kie-ci-bot kie-ci-bot bot removed the WIP 👷‍♂️ Pull Request is on work in progress label Jan 22, 2021
@kie-ci-bot kie-ci-bot bot requested a review from spolti January 22, 2021 18:52
@kie-ci-bot kie-ci-bot bot added bdd-tests 🧪 PR is related to the BDD test framework cli 💻 Pull Request related to cli code base needs review 🔍 Pull Request that needs reviewers labels Jan 22, 2021
@radtriste
Copy link
Contributor Author

full testing was ok

@radtriste radtriste added this to the 1.3.0 milestone Jan 25, 2021
@radtriste radtriste merged commit 617f387 into apache:master Jan 25, 2021
@radtriste radtriste deleted the godog-0.11 branch January 25, 2021 15:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bdd-tests 🧪 PR is related to the BDD test framework cli 💻 Pull Request related to cli code base needs review 🔍 Pull Request that needs reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants