Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

[KOGITO-4361] Invalid image tag for native image #748

Merged
merged 1 commit into from Feb 5, 2021

Conversation

sutaakar
Copy link
Contributor

@sutaakar sutaakar commented Feb 5, 2021

Signed-off-by: Karel Suta ksuta@redhat.com

https://issues.redhat.com/browse/KOGITO-4361

Many thanks for submitting your Pull Request ❤️!

Please make sure your PR meets the following requirements:

  • You have read the contributors' guide
  • Pull Request title is properly formatted: [KOGITO-XYZ] Subject
  • Pull Request contains a link to the JIRA issue
  • Pull Request contains a description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Your feature/bug fix has a unit test that verifies it
  • You've tested the new feature/bug fix in an actual OpenShift cluster
  • You've added a RELEASE_NOTES.md entry regarding this change

Signed-off-by: Karel Suta <ksuta@redhat.com>
@kie-ci-bot kie-ci-bot bot added needs review 🔍 Pull Request that needs reviewers operator ☁️ Pull Request related to kogito-operator code base labels Feb 5, 2021
@sutaakar sutaakar requested review from Kaitou786 and removed request for ricardozanini and spolti February 5, 2021 13:10
@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #748 (f057304) into master (0b5d664) will increase coverage by 8.43%.
The diff coverage is 34.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #748      +/-   ##
==========================================
+ Coverage   38.67%   47.10%   +8.43%     
==========================================
  Files         151      142       -9     
  Lines        6516     5254    -1262     
==========================================
- Hits         2520     2475      -45     
+ Misses       3601     2396    -1205     
+ Partials      395      383      -12     
Flag Coverage Δ
cli 53.13% <33.33%> (-1.18%) ⬇️
controllers 46.09% <35.02%> (?)
operator 44.76% <ø> (+10.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/kogito/command/converter/artifact_converter.go 100.00% <ø> (ø)
...ito/command/converter/binarybuildtype_converter.go 100.00% <ø> (ø)
...md/kogito/command/converter/gitsource_converter.go 100.00% <ø> (ø)
...ogito/command/converter/infraresource_converter.go 100.00% <ø> (ø)
...ito/command/converter/kogitobuildtype_converter.go 77.77% <ø> (ø)
...d/kogito/command/converter/monitoring_converter.go 100.00% <ø> (ø)
...d/kogito/command/converter/properties_converter.go 0.00% <0.00%> (ø)
.../kogito/command/converter/runtimetype_converter.go 80.00% <ø> (ø)
...ogito/command/converter/webhooksecret_converter.go 75.00% <ø> (ø)
cmd/kogito/command/install/factory.go 100.00% <ø> (ø)
... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd0b7a3...46422dd. Read the comment docs.

@sutaakar
Copy link
Contributor Author

sutaakar commented Feb 5, 2021

/jenkins test

Copy link
Contributor

@Kaitou786 Kaitou786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sutaakar for the PR :)

@sutaakar sutaakar added ready 🚀 PR is ready to be merged and removed needs review 🔍 Pull Request that needs reviewers labels Feb 5, 2021
@ricardozanini ricardozanini merged commit 5f7c78c into apache:master Feb 5, 2021
@ricardozanini ricardozanini added this to the 1.3.0 milestone Feb 5, 2021
@sutaakar sutaakar deleted the KOGITO-4361 branch February 5, 2021 15:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
operator ☁️ Pull Request related to kogito-operator code base ready 🚀 PR is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants