Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

[KOGITO-4529] - Throwing nil pointer dereference for Knative broker K… #772

Merged
merged 3 commits into from Feb 24, 2021
Merged

[KOGITO-4529] - Throwing nil pointer dereference for Knative broker K… #772

merged 3 commits into from Feb 24, 2021

Conversation

vaibhavjainwiz
Copy link
Contributor

…ogitoInfra

Jira issue : https://issues.redhat.com/browse/KOGITO-4529

Many thanks for submitting your Pull Request ❤️!

Please make sure your PR meets the following requirements:

  • You have read the contributors' guide
  • Pull Request title is properly formatted: [KOGITO-XYZ] Subject
  • Pull Request contains a link to the JIRA issue
  • Pull Request contains a description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Your feature/bug fix has a unit test that verifies it
  • You've tested the new feature/bug fix in an actual OpenShift cluster
  • You've added a RELEASE_NOTES.md entry regarding this change

@kie-ci-bot kie-ci-bot bot added needs review 🔍 Pull Request that needs reviewers operator ☁️ Pull Request related to kogito-operator code base labels Feb 23, 2021
@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #772 (faf2f4e) into master (0b5d664) will increase coverage by 3.85%.
The diff coverage is 36.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #772      +/-   ##
==========================================
+ Coverage   38.67%   42.53%   +3.85%     
==========================================
  Files         151      138      -13     
  Lines        6516     5276    -1240     
==========================================
- Hits         2520     2244     -276     
+ Misses       3601     2722     -879     
+ Partials      395      310      -85     
Flag Coverage Δ
cli 52.57% <28.22%> (-1.74%) ⬇️
controllers 36.80% <36.80%> (?)
operator 39.67% <37.81%> (+5.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/kogito/command/converter/artifact_converter.go 100.00% <ø> (ø)
cmd/kogito/command/converter/config_converter.go 4.76% <0.00%> (ø)
cmd/kogito/command/converter/envvar_converter.go 100.00% <ø> (ø)
...md/kogito/command/converter/gitsource_converter.go 100.00% <ø> (ø)
...ogito/command/converter/infraresource_converter.go 100.00% <ø> (ø)
...d/kogito/command/converter/monitoring_converter.go 100.00% <ø> (ø)
...d/kogito/command/converter/properties_converter.go 0.00% <0.00%> (ø)
cmd/kogito/command/install/factory.go 100.00% <ø> (ø)
cmd/kogito/command/project/delete_project.go 83.33% <ø> (ø)
cmd/kogito/command/project/project.go 100.00% <ø> (ø)
... and 215 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f424f25...e607ab0. Read the comment docs.

@radtriste radtriste removed their request for review February 23, 2021 17:30
Copy link
Contributor

@sutaakar sutaakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, works as expected.

@ricardozanini
Copy link
Member

ricardozanini commented Feb 24, 2021

@vaibhavjainwiz, can you please rebase the Release Notes?

EDIT: nvm, I saw that you had connectivity problems today. It's so simple that I did it myself via the web UI.

@ricardozanini ricardozanini added ready 🚀 PR is ready to be merged and removed needs review 🔍 Pull Request that needs reviewers labels Feb 24, 2021
@ricardozanini ricardozanini added this to the 1.4.0 milestone Feb 24, 2021
@vaibhavjainwiz
Copy link
Contributor Author

@vaibhavjainwiz, can you please rebase the Release Notes?

EDIT: nvm, I saw that you had connectivity problems today. It's so simple that I did it myself via the web UI.

Thanks @ricardozanini

@spolti spolti merged commit 8d1f15b into apache:master Feb 24, 2021
@vaibhavjainwiz vaibhavjainwiz deleted the KOGITO-4529 branch March 2, 2021 14:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
operator ☁️ Pull Request related to kogito-operator code base ready 🚀 PR is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants