Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

[KOGITO-4572] KogitoInfra doesn't detect running Infinispan instance #782

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

sutaakar
Copy link
Contributor

@sutaakar sutaakar commented Mar 3, 2021

Signed-off-by: Karel Suta ksuta@redhat.com

https://issues.redhat.com/browse/KOGITO-4572

Many thanks for submitting your Pull Request ❤️!

Please make sure your PR meets the following requirements:

  • You have read the contributors' guide
  • Pull Request title is properly formatted: [KOGITO-XYZ] Subject
  • Pull Request contains a link to the JIRA issue
  • Pull Request contains a description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Your feature/bug fix has a unit test that verifies it
  • You've tested the new feature/bug fix in an actual OpenShift cluster
  • You've added a RELEASE_NOTES.md entry regarding this change

@kie-ci-bot kie-ci-bot bot added needs review 🔍 Pull Request that needs reviewers operator ☁️ Pull Request related to kogito-operator code base labels Mar 3, 2021
@sutaakar
Copy link
Contributor Author

sutaakar commented Mar 3, 2021

I didn't update the readme as the issue is related to https://issues.redhat.com/browse/KOGITO-4477 which is targeting same release, previously it worked well.

@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #782 (6df57d7) into master (0b5d664) will increase coverage by 3.88%.
The diff coverage is 38.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #782      +/-   ##
==========================================
+ Coverage   38.67%   42.55%   +3.88%     
==========================================
  Files         151      138      -13     
  Lines        6516     5280    -1236     
==========================================
- Hits         2520     2247     -273     
+ Misses       3601     2723     -878     
+ Partials      395      310      -85     
Flag Coverage Δ
cli 52.57% <28.22%> (-1.74%) ⬇️
controllers 36.80% <36.80%> (?)
operator 39.70% <42.81%> (+5.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/kogito/command/converter/artifact_converter.go 100.00% <ø> (ø)
cmd/kogito/command/converter/config_converter.go 4.76% <0.00%> (ø)
cmd/kogito/command/converter/envvar_converter.go 100.00% <ø> (ø)
...md/kogito/command/converter/gitsource_converter.go 100.00% <ø> (ø)
...ogito/command/converter/infraresource_converter.go 100.00% <ø> (ø)
...d/kogito/command/converter/monitoring_converter.go 100.00% <ø> (ø)
...d/kogito/command/converter/properties_converter.go 0.00% <0.00%> (ø)
cmd/kogito/command/install/factory.go 100.00% <ø> (ø)
cmd/kogito/command/project/delete_project.go 83.33% <ø> (ø)
cmd/kogito/command/project/project.go 100.00% <ø> (ø)
... and 215 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6292cf2...f5890ad. Read the comment docs.

Signed-off-by: Karel Suta <ksuta@redhat.com>
@sutaakar
Copy link
Contributor Author

sutaakar commented Mar 3, 2021

/jenkins test

Copy link
Member

@MarianMacik MarianMacik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Close enough :)

@ricardozanini
Copy link
Member

Maybe we can also open a follow-up JIRA to update ISPN reference?

@sutaakar
Copy link
Contributor Author

sutaakar commented Mar 3, 2021

@ricardozanini Created https://issues.redhat.com/browse/KOGITO-4577

@ricardozanini
Copy link
Member

/jenkins test

@sutaakar sutaakar added ready 🚀 PR is ready to be merged and removed needs review 🔍 Pull Request that needs reviewers labels Mar 5, 2021
@sutaakar
Copy link
Contributor Author

sutaakar commented Mar 5, 2021

Should we wait for #781 before merging this PR?

@ricardozanini
Copy link
Member

No, this is critical. Merging.

@ricardozanini ricardozanini merged commit 6baa538 into apache:master Mar 5, 2021
@sutaakar sutaakar deleted the KOGITO-4572 branch March 5, 2021 12:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
operator ☁️ Pull Request related to kogito-operator code base ready 🚀 PR is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants