New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KOGITO-162] - Migrate the Kogito base images from centos to ubi8 #30
Conversation
@mswiderski SHould the GraalVM be updated to 19.1.1? |
Just tested https://github.com/kiegroup/kogito-examples/tree/0.2.0/drools-quarkus-example on openshift with the new images, works as expected. |
@spolti we have a JIRA to upgrade to 19.1.1. But once we upgrade the Kogito runtimes to a compatible quarkus version, which is 0.20: https://issues.jboss.org/browse/KOGITO-98 Feel free to assign this JIRA to you and work on it. Many thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ImageStream also need to be updated?
Just found the file, lgtm.
Have you tested onboarding example? Reason why i as is that is used https and by that some native library from GraalVM so would be good to check that UBI 8 has all libraries needed to make the https based connections. When it comes to graalvm version - I will try to do upgrade of quarkus version soon and then we align graalvm with it. Will let you know |
@mswiderski thanks for noticing the TLS thing. This is really a PITA, but thankfully they made some changes on 19.1.1/Quarkus 0.20 to avoid the issues we're having. |
@mswiderski not yet, thanks for remind me, will test it before remove the wip label. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Micro things. But I guess we should coordinate this merge with https://issues.jboss.org/browse/KOGITO-98
@mswiderski @ricardozanini just tried the onboarding example, work as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, if we merge the upgrade of quarkus (kiegroup/kogito-bom#48) then we should upgrade graalvm here as well.
@mswiderski we already upgraded to GraalVM 19.1.x and will merge this soon to run e2e tests with kiegroup/kogito-bom#48. If you decide to not merge for 0.3.0, we can rollback this upgrade. |
Signed-off-by: Filippe Spolti <fspolti@redhat.com>
This PR is ready. |
…evmode images (apache#30) This is required by Parodos because we are doing an internal release and Kogito artifacts will not be available on MRRC
Signed-off-by: Filippe Spolti fspolti@redhat.com