Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KOGITO-162] - Migrate the Kogito base images from centos to ubi8 #30

Merged
merged 1 commit into from Aug 21, 2019

Conversation

spolti
Copy link
Member

@spolti spolti commented Aug 16, 2019

Signed-off-by: Filippe Spolti fspolti@redhat.com

@spolti spolti added the WIP 👷‍♂️ Pull Request is on work in progress label Aug 16, 2019
@spolti spolti requested a review from mswiderski August 16, 2019 22:16
@spolti
Copy link
Member Author

spolti commented Aug 16, 2019

@mswiderski SHould the GraalVM be updated to 19.1.1?

@spolti
Copy link
Member Author

spolti commented Aug 16, 2019

Just tested https://github.com/kiegroup/kogito-examples/tree/0.2.0/drools-quarkus-example on openshift with the new images, works as expected.

@ricardozanini
Copy link
Member

ricardozanini commented Aug 17, 2019

@spolti we have a JIRA to upgrade to 19.1.1. But once we upgrade the Kogito runtimes to a compatible quarkus version, which is 0.20:

https://issues.jboss.org/browse/KOGITO-98

Feel free to assign this JIRA to you and work on it. Many thanks!

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ImageStream also need to be updated?

Just found the file, lgtm.

@mswiderski
Copy link
Contributor

Have you tested onboarding example? Reason why i as is that is used https and by that some native library from GraalVM so would be good to check that UBI 8 has all libraries needed to make the https based connections.

When it comes to graalvm version - I will try to do upgrade of quarkus version soon and then we align graalvm with it. Will let you know

@ricardozanini
Copy link
Member

@mswiderski thanks for noticing the TLS thing. This is really a PITA, but thankfully they made some changes on 19.1.1/Quarkus 0.20 to avoid the issues we're having.

@spolti
Copy link
Member Author

spolti commented Aug 19, 2019

@mswiderski not yet, thanks for remind me, will test it before remove the wip label.
@ricardozanini cool, I can take deal with the graalvm update.

Thanks.

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Micro things. But I guess we should coordinate this merge with https://issues.jboss.org/browse/KOGITO-98

s2i/modules/add-kogito-user/module.yaml Outdated Show resolved Hide resolved
s2i/modules/add-kogito-user/module.yaml Outdated Show resolved Hide resolved
@spolti
Copy link
Member Author

spolti commented Aug 21, 2019

@mswiderski @ricardozanini just tried the onboarding example, work as expected.

Copy link
Contributor

@mswiderski mswiderski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, if we merge the upgrade of quarkus (kiegroup/kogito-bom#48) then we should upgrade graalvm here as well.

@ricardozanini
Copy link
Member

@mswiderski we already upgraded to GraalVM 19.1.x and will merge this soon to run e2e tests with kiegroup/kogito-bom#48. If you decide to not merge for 0.3.0, we can rollback this upgrade.
Sorry, I didn't see your comment before.

Signed-off-by: Filippe Spolti <fspolti@redhat.com>
@spolti
Copy link
Member Author

spolti commented Aug 21, 2019

This PR is ready.

@spolti spolti removed the WIP 👷‍♂️ Pull Request is on work in progress label Aug 21, 2019
@ricardozanini ricardozanini merged commit 2d4ff4e into apache:master Aug 21, 2019
@spolti spolti deleted the KOGITO-162 branch August 21, 2019 19:42
rgdoliveira added a commit to rgdoliveira/incubator-kie-kogito-images that referenced this pull request Apr 15, 2024
…evmode images (apache#30)

This is required by Parodos because we are doing an internal release and Kogito artifacts will not be available on MRRC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants