Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KOGITO-4654: Format codebase and check formatting as part of full downstream build #444

Closed
wants to merge 29 commits into from

Conversation

jomarko
Copy link
Contributor

@jomarko jomarko commented Mar 11, 2021

The formatting changes were split into commits per 'package' to facilitate review.

@domhanak
Copy link
Contributor

domhanak commented Mar 11, 2021

@jomarko I went throught the Formatted packages/vscode-extension-pack-kogito-kie-editors/ and the changes seemed valid and ok. There might be some issues with tslint now, but I need to wait for the it-tests for vscode to finish :)

@manstis
Copy link
Contributor

manstis commented Mar 11, 2021

@jomarko I have no problem with the reformatting of either pmml-editor-marshaller or pmml-editor. Thank-you.

@ederign ederign requested review from tiagobento, tomasdavidorg and ederign and removed request for tomasdavidorg March 11, 2021 14:13
Copy link
Contributor

@ederign ederign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will require further discussion. Meanwhile, please hold down the merge.

@jomarko
Copy link
Contributor Author

jomarko commented Mar 12, 2021

Closed as required on google chat thread.

@jomarko jomarko closed this Mar 12, 2021
@jomarko
Copy link
Contributor Author

jomarko commented Mar 26, 2021

Replaced by #465

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants