Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KOGITO-5428: Introduce DMN Runner cypress test #621

Merged
merged 5 commits into from Sep 16, 2021
Merged

KOGITO-5428: Introduce DMN Runner cypress test #621

merged 5 commits into from Sep 16, 2021

Conversation

jomarko
Copy link
Contributor

@jomarko jomarko commented Sep 9, 2021

No description provided.

@jomarko jomarko marked this pull request as ready for review September 13, 2021 13:16
@jomarko jomarko added the DO NOT MERGE Draft PR, not ready for merging label Sep 13, 2021
@jomarko jomarko force-pushed the KOGITO-5428 branch 4 times, most recently from e84752b to 74fef44 Compare September 15, 2021 07:03
@jomarko jomarko removed the DO NOT MERGE Draft PR, not ready for merging label Sep 16, 2021
@domhanak
Copy link
Contributor

domhanak commented Sep 16, 2021 •
edited

@tiagobento In the logs of CI :: Monorepo / monorepo-pr-ci (ubuntu-latest) (pull_request) I can see we are building packages like kie-editors-standalone, desktop and more. I thought we should be building only packages that area affected by these changes. Is there a bug in the behavior or is this because there is a changes in build-env package? Thanks for clarification in advance!

domhanak
domhanak requested changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@domhanak domhanak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we can merge once the test is passing. Currently there is an issue, also visible on CI now.

 1) DMN Runner Test
       Test DMN Runner on DMN sample:
     AssertionError: Timed out retrying after 10000ms: expected '<div.pf-c-description-list__text>' to be 'visible'

This element `<div.pf-c-description-list__text>` is not visible because its content is being clipped by one of its parent elements, which has a CSS property of overflow: `hidden`, `scroll` or `auto`

tomasdavidorg
tomasdavidorg approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@tomasdavidorg tomasdavidorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me when it is green 🟢.

@jomarko
Copy link
Contributor Author

jomarko commented Sep 16, 2021

@domhanak, thank you for the review, I have updated the assertion in last commit, lets see what our CI automation results are.

@tomasdavidorg thank you for the review too.

domhanak
domhanak approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@domhanak domhanak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally it passes for me. Thanks @jomarko for new test! Great work

@tiagobento tiagobento merged commit 20ae982 into apache:main Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagobento tiagobento tiagobento approved these changes

@tomasdavidorg tomasdavidorg tomasdavidorg approved these changes

@domhanak domhanak domhanak approved these changes

@ederign ederign Awaiting requested review from ederign ederign is a code owner

Assignees
No one assigned
Labels
order: 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jomarko @domhanak @tiagobento @tomasdavidorg