Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw diagram requests should interrupt/cancel old requests #161

Open
NiklasRentzCAU opened this issue Apr 20, 2023 · 0 comments
Open

Draw diagram requests should interrupt/cancel old requests #161

NiklasRentzCAU opened this issue Apr 20, 2023 · 0 comments
Labels
enhancement New feature or request LSP Affect the klighd language server.

Comments

@NiklasRentzCAU
Copy link
Member

Every diagram request sent to the diagram server will currently be processed and a new diagram will be sent for each request. When new multiple requests arrive at the same time, they will get blocked by the synchronization, but eventually finish. I propose a new process for this:

  • A single diagram request should always be handled and completed.
  • A second diagram request (for the same diagram widget) should wait until the first one has finished.
  • Any other further diagram request should cancel all previously waiting diagram requests (as they will not be needed anymore), thus being the only waiting request.

This will prevent issues currently happening for example during the simulation of SCCharts, where the current values are added to the edges in the diagram: A rapidly ticking simulation will cause a long queue of diagram requests to be stuttered off over time.

@NiklasRentzCAU NiklasRentzCAU added enhancement New feature or request LSP Affect the klighd language server. labels Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request LSP Affect the klighd language server.
Projects
None yet
Development

No branches or pull requests

1 participant