Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a zoom to fit the diagram content strategy for sparsely populated diagrams #24

Closed
NiklasRentzCAU opened this issue Apr 9, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@NiklasRentzCAU
Copy link
Member

This is related to KIPRA-1895.

The current zoom to fit behavior aligns the viewport with the size of the current diagram clip node, which might be much larger (or even smaller) than the bounding box of the actual (nested) diagram content.

This may be given in particular if the diagram clip node's (potentially large amount of) ports is turned invisible.

A dedicated zooming strategy ZOOM_TO_FIT_CONTENT would be beneficial than.

@NiklasRentzCAU NiklasRentzCAU added the enhancement New feature or request label Apr 9, 2020
@NiklasRentzCAU
Copy link
Member Author

This issue is migrated from the old KIELER Pragmatics JIRA issue tracker. See the old discussion on this ticket in KIPRA-1976.

@NiklasRentzCAU
Copy link
Member Author

@sailingKieler looking at the old ticket in the pragmatics repository, it looks like this issue is already fixed, but was never closed. Is this fixed already? If so, please close this issue agian.

@sailingKieler
Copy link
Member

@sailingKieler looking at the old ticket in the pragmatics repository, it looks like this issue is already fixed, but was never closed. Is this fixed already? If so, please close this issue again.

That's true and might be as this feature never released before v1.0.0.
We could add pointers to the corresponding changes here and close I think.

@NiklasRentzCAU
Copy link
Member Author

Fixed since this commit, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants