-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect end points with cross hierarchical edges and node padding #10
Comments
I suspect it's a bug. I'll check it and let you know once I know more. |
Thanks! |
Actually, the padding values are not automatically added to the bend points (neither to the child nodes). Have a look at the coordinate system of the KGraph. There the padding is called insets but has the same effect. So as long as you use the relative coordinates, you have to add the insets/padding yourself. Your modification of the hierarchy2 example resulted in wrong positions because there was a bug in the d3 extension. It didn't consider the padding when computing absolute coordinates. I added a padding example. Let me know if this resolves your issues. |
Ah right, ok. I'm not actually using D3, but I can use the toAbsolute code in the d3 extension for my use. Thanks for this library btw, it's brilliant. I'm using it for an open source node based shader editor in React Native.
|
Thanks, we do our best :). |
The thing is React Native passes both the nodejs test and the webworker test. Could the tests be 'else if' instead, so that two can't pass? |
Probably, though I feel as if we had an 'else if' somewhere and had to remove it for something else to work (see #3). |
Hi,
I need a sub graph to have padding to ensure there will be space above it to put some other controls.
But when I set the padding to a non-zero value, the edges going into and out of that sub graph ignore it, causing a misalignment.
To see this, look at the hierarchy2 demo and add a top padding to the sub graph. You'll see that the edge placement is wrong.
Is this a bug or is there some setting I'm missing?
Thanks
The text was updated successfully, but these errors were encountered: