Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New broker templete #47

Closed
bibinvargheset opened this issue Aug 23, 2022 · 1 comment
Closed

New broker templete #47

bibinvargheset opened this issue Aug 23, 2022 · 1 comment

Comments

@bibinvargheset
Copy link

I saw thw new broker templete, but it is missing key information ,

  1. There should what is expected return format for each methods
  2. it does not includes the data loaded info since each broker may have different data methods and different instruments, there should be a possibility of addinfg that
@jmcph4 jmcph4 mentioned this issue Oct 14, 2022
Closed
@kieran-mackle
Copy link
Owner

Hi @bibinvargheset,

I have added an abstract class autotrader.brokers.broker.AbstractBroker (#60) which provides an interface for all broker modules. I have also updated the template file accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bibinvargheset @kieran-mackle