Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

讨论:components 中的组件不应该直接访问 redux 和 router #8

Closed
yuezk opened this issue Jan 2, 2018 · 1 comment
Closed

Comments

@yuezk
Copy link

yuezk commented Jan 2, 2018

首先,这是一个很好的项目,但是有个点想和大家讨论一下:

就是 components 的组件应该只和渲染有关,不关心数据和路由。数据和路由应该由 containers 中的组件去做,这个项目中 containers 中的部分组件直接包了一层 components 中的组件就导出了,应该是不太合适的。有些 components 中的组件直接访问了 redux 和 router,感觉也不太合适。

@KieSun
Copy link
Owner

KieSun commented Jan 2, 2018

确实有几个做的不妥,稍后我会修改掉。

@KieSun KieSun closed this as completed Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants