Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to use of ES6 Classes #4

Closed
mitogh opened this issue Jul 31, 2016 · 6 comments
Closed

Refactor to use of ES6 Classes #4

mitogh opened this issue Jul 31, 2016 · 6 comments

Comments

@mitogh
Copy link
Contributor

mitogh commented Jul 31, 2016

I was wondering if you are open to a Refactor on this in order to use ES6 Classes to make it a little bit more familiar with Java I'm happy to open a PR if you want, just wanted to ask first.

Thank you.

@Kikobeats
Copy link
Owner

The problem with that is first compatibility with node versions and second, at this moment, ES6 optimization for v8 is too poor.

@mitogh
Copy link
Contributor Author

mitogh commented Jul 31, 2016

Ok.

I was planing to have just ES6 for development and deliver ES5 to the build as the entry point using Babel, so in that way the JS keeps being compatible with any browser.

On Jul 31, 2016, at 11:00 AM, Kiko Beats notifications@github.com wrote:

The problem with that is first compatibility with node versions and second, at this moment, ES6 optimization for v8 is too poor.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #4 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/ADvViWSrbJ8s7qui9UndBxUG7dQ73JXdks5qbOLZgaJpZM4JZBK-.

@Kikobeats
Copy link
Owner

That's sounds cool, but honestly I think that you are investing effort, time and compilation time to be in the same starting point than now 😄

@mitogh
Copy link
Contributor Author

mitogh commented Jul 31, 2016

Well I’m going to have some time waiting on the Airport ✈️,

Just wanted to know if you are open to this before start with this tomorrow.

Thanks :)

On Jul 31, 2016, at 11:43 AM, Kiko Beats notifications@github.com wrote:

That's sounds cool, but honestly I think that you are investing effort, time and compilation time to be in the same starting point than now 😄


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #4 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/ADvVieH-9WbZBALAw8XVPQNL3IqEdl5Rks5qbOzBgaJpZM4JZBK-.

@Kikobeats
Copy link
Owner

thanks for read the code but not really!

so I'm going to contact with you to be part of other interesting projects that need people :)

@mitogh
Copy link
Contributor Author

mitogh commented Jul 31, 2016

Sounds good thanks.

On Jul 31, 2016, at 11:50 AM, Kiko Beats notifications@github.com wrote:

thanks for read the code but not really!

so I'm going to contact with you to be part of other interesting projects that need people :)


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #4 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/ADvVifjwcfndLPJluWJjKMLb5BCdy9qjks5qbO6JgaJpZM4JZBK-.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants