Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up pattern centre, detector and gnomonic projection classes #186

Closed
wants to merge 1 commit into from

Conversation

hakonanes
Copy link
Member

@hakonanes hakonanes commented May 22, 2020

Signed-off-by: Håkon Wiik Ånes hwaanes@gmail.com

Description

This is an attempt to establish traditional EBSD reference systems for the signal and navigation axes, based upon work made available in the paper Britton, T. B., Jiang, J., Guo, Y., Vilalta-Clemente, A., Wallis, D., Hansen, L. N., Winkelmann, A., Wilkinson, A. J.: Tutorial: Crystal orientations and EBSD - Or which way is up?, Materials Characterization 117,113–126, 2016, doi: https://doi.org/10.1016/j.matchar.2016.04.008.

I imagine the final product of this PR being plotting plane traces as line markers superimposed on EBSD patterns. We'll see how it goes.

It is a work in progress.

Checklist

Will add more actions as the work comes along.

Minimal example of the bug fix or new feature

Will add as the work comes along.

>>> import kikuchipy as kp
>>> import numpy as np
>>> s = kp.signals.EBSD(np.zeros((10, 10, 10, 10)))
>>> # Your new feature...

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    the unreleased section in doc/changelog.rst.

Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes added enhancement New feature or request work in progress discussion Discussion labels May 22, 2020
@hakonanes hakonanes added this to the v0.3.0 milestone May 22, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.5%) to 98.464% when pulling f4771e4 on hakonanes:gnomic-projection into d82a939 on kikuchipy:master.

@hakonanes
Copy link
Member Author

Let's call it gnomonic projection as well...

@hakonanes hakonanes changed the title Set up pattern centre, detector and gnomic projection classes Set up pattern centre, detector and gnomonic projection classes May 23, 2020
@hakonanes
Copy link
Member Author

All of this will be implemented in #204.

@hakonanes hakonanes closed this Sep 3, 2020
@hakonanes hakonanes deleted the gnomic-projection branch November 30, 2020 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discussion enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants