Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NORDIF read. sig/nav size params overwrite + start io-tests #77

Merged
merged 5 commits into from Sep 22, 2019

Conversation

hakonanes
Copy link
Member

@hakonanes hakonanes commented Sep 20, 2019

This PR addresses #67 and adds tests to the NORDIF reader and writer.

WIP since I'm in the process of writing the tests. I use HyperSpy's tests for the Blockfile format as inspiration (https://github.com/hyperspy/hyperspy/blob/RELEASE_next_minor/hyperspy/tests/io/test_blockfile.py).

Tests left:

  • Loading testing for data shape and axes_manager, default input
  • Loading testing input parameters pattern_size and scan_size
  • Loading testing input parameters setting_file
  • Load and save cycle (checking data shape and metadata/axes manager)
    - [ ] Load and save checking changing of axes manager All data info except intensities are read from the same settings textfile.
  • Different loading modes (to memory, inplace, read only and lazy)
  • Write signal from numpy arrays to NORDIF format
  • Write 3D signal to NORDIF format (one navigation axis)
  • Write 2D signal to NORDIF format (one pattern)
  • Padding of missing patterns (when input scan_size or the scan_size read from Setting.txt is larger than file size)

Signed-off-by: Håkon Wiik Ånes hwaanes@gmail.com

Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes added bug Something isn't working status: WIP labels Sep 20, 2019
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes merged commit c810bf1 into pyxem:master Sep 22, 2019
@hakonanes hakonanes deleted the fix-nordif-reader-input branch September 22, 2019 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant