Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XSS Issue #62

Closed
MSylvia opened this issue Jul 8, 2015 · 6 comments
Closed

XSS Issue #62

MSylvia opened this issue Jul 8, 2015 · 6 comments
Assignees
Milestone

Comments

@MSylvia
Copy link

MSylvia commented Jul 8, 2015

Any code in the content field get evaluated.

[  
   "line",
   {  
      "timestamp":0000000000000,
      "streamid":"rtail.org",
      "host":"XXX.XXX.XXX.XXX",
      "port":50049,
      "content":"<script>window.top.location.href=\"http://www.google.com\"</script>",
      "type":"string"
   }
]

This would redirect the user to http://www.google.com

@MSylvia
Copy link
Author

MSylvia commented Jul 8, 2015

Also see Issue #61.

@kilianc
Copy link
Owner

kilianc commented Jul 8, 2015

I think I fixed this in: #58

@kilianc
Copy link
Owner

kilianc commented Jul 8, 2015

@MSylvia thanks for reporting this first of all, I created a stream called "XSS no more" that should prove the fix works but since you're here, two more eyes would not hurt.

@MSylvia
Copy link
Author

MSylvia commented Jul 8, 2015

Ah I see that now. At the time I wrote it the current version of rtail.org had this issue. The fix might not have been deployed.

@kilianc
Copy link
Owner

kilianc commented Jul 8, 2015

@MSylvia yes, the demo is using a s3 bucket cached in ram for many hours. But someone has been faster than me tonight. I had to restart the demo and everything is working now. Along with other fixes and features like ellipsis for long names in the sidebar and resizable sidebar!

Shall we close this?

@MSylvia
Copy link
Author

MSylvia commented Jul 8, 2015

Yes. Seems to be resolved. :)

@MSylvia MSylvia closed this as completed Jul 8, 2015
@kilianc kilianc added this to the v0.2.0 milestone Jul 8, 2015
@kilianc kilianc self-assigned this Jul 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants