Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error on compiling with angular-cli (1.0.0-rc.0) #17

Closed
maku opened this issue Mar 6, 2017 · 11 comments
Closed

error on compiling with angular-cli (1.0.0-rc.0) #17

maku opened this issue Mar 6, 2017 · 11 comments

Comments

@maku
Copy link

maku commented Mar 6, 2017

When trying to use ngx-quill with angular-cli (1.0.0-rc.0) and angular (4.0.0-rc.2) I get an error on compiling regarding quill.module.ts

ERROR in Error encountered resolving symbol values statically. Calling function 'makeDecorator', function calls are not supported. Consider replacing the function or lambda with a reference to an exported function

@KillerCodeMonkey
Copy link
Owner

KillerCodeMonkey commented Mar 6, 2017

seems like it is an issue with aot. this needs a metadata-file. if you have further information. let me know.

edit:
Please try angular ^2.4.5 .. i am using this version. Do not know if cli or angular introduced some incompatibilities.

@KillerCodeMonkey
Copy link
Owner

KillerCodeMonkey commented Mar 6, 2017

Again:

tested with:

@angular/cli: 1.0.0-rc.1
node: 7.4.0
os: darwin x64
@angular/common: 2.4.9
@angular/compiler: 2.4.9
@angular/core: 2.4.9
@angular/forms: 2.4.9
@angular/http: 2.4.9
@angular/platform-browser: 2.4.9
@angular/platform-browser-dynamic: 2.4.9
@angular/router: 3.4.9
@angular/cli: 1.0.0-rc.1
@angular/compiler-cli: 2.4.9

no problems --> works like charm.

Occurs because the different angular versions. please use the peer dependencies of ngx-quill. Thanks

I will upgrade or make it working if angular 4 is final

@maku
Copy link
Author

maku commented Mar 7, 2017

When you generate the cli project for ng4 it does not work (and ng4 is not far away)

.e.g.

ng new ngx-quill-test --style=scss --ng4 true

@KillerCodeMonkey
Copy link
Owner

yeah i know... i tested it with v4. But i support this repo all on my own and in my free time.

And before supporting a rc, i will wait until it is final

@maku
Copy link
Author

maku commented Mar 7, 2017

Yeah, I see, thank you for your effort.

BTW, the funny thing is that your source works without problems with ng4. Only the distributed lib does not work with ng4...

@KillerCodeMonkey
Copy link
Owner

what do you mean with distributed lib?

@maku
Copy link
Author

maku commented Mar 7, 2017

The code which is used when I install the lib via npm (vs. only copying the source in the project)

@KillerCodeMonkey
Copy link
Owner

could you try the following?:

replace in the package.json of ngx-quill in your node_modules the angular version with: ^2.4.1 || 4.0.0-rc.2

@maku
Copy link
Author

maku commented Mar 8, 2017

what I meant was: it works when you copy your sourcefiles directly in a ng4 project....

@KillerCodeMonkey
Copy link
Owner

i know, but i asked you if you may test it in your project, if you hacky set the angular versions in ngx-quill in the node_modules ;).

If you do not want to do it.. no problem

@maku
Copy link
Author

maku commented Mar 8, 2017

O.k. I did this. But it has no effect (as expected).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants