-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build error because of missed ZstdNet.1.0.0 package #1
Comments
I have plans for .net core version, actually I stripped off all dependencies (e.g. System.Data) to use in minimal environment, however that led to disabling compression at all. |
I'm going to do that this weekend and back to you with the results. Compression should be preserved as it is important in my usage scenario (BI tool connector to ClickHouse). |
I've packaged/published this driver to nuget and will update it when something significant arrive (e.g. bugfix), so when you finish adding features consider moving to binary distribution. |
Also I've added coco/r executable and included parser/scanner files regeneration prior to each build. |
@killwort awsome, thanks! |
It seems ClickHouse.Ado.csproj has references to 'ZstdNet' package that is no longer needed and causes build errors:
I haven't tested the connector yet mostly because I have .NET Core appplication.
Do you have any plans to add nestandard build? I see that only non-common dependency is 'lz4net' and it already has netstandard build ( https://www.nuget.org/packages/lz4net/ ).
Also I think it is good idea to publish 'ClickHouse.Ado' on nuget :-)
BTW, I can help with these 2 things: migrate csproj to VS-2017 format that supports multiple targets at once (net451 / netstandard1.x) and nuget package generation with 'dotnet pack'.
The text was updated successfully, but these errors were encountered: