Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClickHouseDataReader.GetFieldType returns type of internal class instead of value type #6

Closed
VitaliyMF opened this issue May 30, 2017 · 1 comment
Closed

ClickHouseDataReader.GetFieldType returns type of internal class instead of value type #6

VitaliyMF opened this issue May 30, 2017 · 1 comment

Comments

@VitaliyMF
Copy link
Contributor

It seems ClickHouseDataReader.GetFieldType works incorrectly; it returns type of the internal class that represents ClickHouse type (like 'ClickHouse.Ado.Impl.ColumnTypes.SimpleColumnType`1[System.Byte]') instead of real .NET value type. These classes are internal and this type is useless.
killwort added a commit that referenced this issue Jun 2, 2017
@killwort
#6. IDataReader.GetFieldType now return .NET BCL type instead of inte…
da52457 
…rnal column type.
@killwort
Copy link
Owner

killwort commented Jun 2, 2017

Added internal CLRType to ColumnType and returning it upon GetFieldType calls.
Assembly/file version and nuget package updated to 1.0.2

@killwort killwort closed this as completed Jun 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@VitaliyMF @killwort