Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reqwest dependency should have default-features = false #61

Closed
matt-phylum opened this issue Jun 13, 2023 · 1 comment · Fixed by #67
Closed

reqwest dependency should have default-features = false #61

matt-phylum opened this issue Jun 13, 2023 · 1 comment · Fixed by #67
Milestone
22.0.300

Comments

@matt-phylum
Copy link

Because Cargo does not have negative features, keycloak's dependency on reqwest without default-features = false causes a dependency on reqwest's default-tls feature, and crates dependent on keycloak cannot turn this dependency off if they don't want it.
@kilork
Copy link
Owner

kilork commented Jun 13, 2023

Hi, thanks, this is very nice thing to have. We need to take next opportunity with version upgrade this, as it seems to me to be a breaking change.

@kilork kilork mentioned this issue Aug 22, 2023
Closed
@kilork kilork linked a pull request Oct 8, 2023 that will close this issue
Do not use default feature in reqwest dependency #67
Merged
@kilork kilork closed this as completed in #67 Oct 9, 2023
@kilork kilork added this to the 22.0.300 milestone Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
22.0.300
Development

Successfully merging a pull request may close this issue.

Do not use default feature in reqwest dependency kilork/keycloak
2 participants
@kilork @matt-phylum