Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hdfs_native::Client::new_with_config cannot be used because the Configuration type is not public. #65

Closed
Xuanwo opened this issue Jan 8, 2024 · 4 comments

Comments

@Xuanwo
Copy link
Contributor

Xuanwo commented Jan 8, 2024

image

Do you want to expose Configuration directly? I'm willing to submit a PR for this.

@zuston
Copy link
Contributor

zuston commented Jan 8, 2024

Oh .yes. Feel free to fix this, I hope this could be fixed ASSP.

@Kimahriman
Copy link
Owner

Ah should have caught that, I assumed rust would have complained internally if that was the case. Lets just have that method take a HashMap instead? No reason to really expose the config right now I don't think

@Xuanwo
Copy link
Contributor Author

Xuanwo commented Jan 8, 2024

Ah should have caught that, I assumed rust would have complained internally if that was the case. Lets just have that method take a HashMap instead? No reason to really expose the config right now I don't think

Looks nice to me. I will start a PR for this tomorrow.

@Kimahriman
Copy link
Owner

Resolved by #66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants