Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard showing 'wrong' data at turn of month #1801

Closed
areanod opened this issue Jul 3, 2020 · 6 comments · Fixed by #1802
Closed

Dashboard showing 'wrong' data at turn of month #1801

areanod opened this issue Jul 3, 2020 · 6 comments · Fixed by #1802
Milestone

Comments

@areanod
Copy link

areanod commented Jul 3, 2020

Describe the bug
In the dashboard section "My working hours" the data field for "working hours this month" shows the amount of hours of the previous month when a week consists of both the end of a month and the beginning of the next one.
I realized this today (July, 3rd) when I had more time in this month than in this week which shouldn't be possible in the first week of the month.

Screenshots
screenshot03072020

Additional context
Add any other context about the problem here.

  • Kimai version 2 (1.9 stable)
  • PHP version (7.3)

While writing this post I realized that this behavior might be by design. Dunno if I'm the only one who was confused by this but maybe the description of this field could by changed to something more dynamic, e.g from "working hours this month" to "working hours in $month".
Another possibility to clarify which months data is being displayed in that field could be something like an indicator, for example (pardon my paintbrush ;)):
example

@kevinpapst
Copy link
Member

No, you are not the only one 😁 Actually I am working at it right now.
Yes, it is by design, so not a bug (as in wrong behavior) but more of a design flaw.
I am currently trying to incorporate the day/week/month into the translation, but that is rather hard to read when you scan over the text.

Highlighting some areas is an interesting idea, but way too complex.

Probably its better to to use the end day to calculate the month/year, but then: what if the friday is the first day of the month?
That would be wrong somehow as well...

@areanod
Copy link
Author

areanod commented Jul 3, 2020

Thx for your quick reply, I really appreciate this!

Probably its better to to use the end day to calculate the month/year, but then: what if the friday is the first day of the month?
That would be wrong somehow as well...

I get what you mean but I think that showing the current info makes the most sense on a dashboard. You could make this an option for a user's profile, like "show data of previous month if less than 1/2/3/4/5/6 days of week are from the next month"

I have no clue how much work that is but if you want to give the user the possibility to access statistical data like hours worked in XX month I think it would good to give the user an additonal section, called "Statistics". (not that I want to make this a feature request now :))

@kevinpapst
Copy link
Member

A reporting section is long outstanding, I know. It will come, no need to open a request for that (multiple are existing for that already).

So I changed the labels like this:
Bildschirmfoto 2020-07-03 um 23 26 02

What do you think?

@areanod
Copy link
Author

areanod commented Jul 3, 2020

A reporting section is long outstanding, I know. It will come, no need to open a request for that (multiple are existing for that already).

I'm looking forward to it!

What do you think?
i think you are working far more documented hours than me per year ;)
As for the caption: I like it, thank you so much!

@areanod areanod closed this as completed Jul 3, 2020
@kevinpapst
Copy link
Member

LOL, thats just my development demo. I wish that would be paid hours...

@github-actions
Copy link

github-actions bot commented Oct 9, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging a pull request may close this issue.

2 participants