Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inaccuracies in Kimai Reporting Documentation #2019

Closed
theapu opened this issue Oct 5, 2020 · 3 comments
Closed

Inaccuracies in Kimai Reporting Documentation #2019

theapu opened this issue Oct 5, 2020 · 3 comments

Comments

@theapu
Copy link

theapu commented Oct 5, 2020

Description
In the Kimai Reporting Documentation Extending the reports section at
https://www.kimai.org/documentation/reporting.html#extending-the-reports I have noticed following two inaccuracies

  1. public function onMainMenuConfigure(ReportingEvent $event)
    should be
    public function onReportingMenu(ReportingEvent $event)
    in ReportingEventSubscriber.php

2.use App\Reporting\Report; is also required in ReportingEventSubscriber.php

Kindly update Documentation.

Additional context

  • Kimai version: 1.10
@kevinpapst
Copy link
Member

True, thanks for the report 😁

Needs updating here: https://github.com/kimai/www.kimai.org/blob/master/_documentation/reporting.md

@kevinpapst
Copy link
Member

Fixed by kimai/www.kimai.org#77

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants