Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent bookings with same start / stop time #2342

Closed
HeinzWuert opened this issue Feb 11, 2021 · 8 comments · Fixed by #3304
Closed

Prevent bookings with same start / stop time #2342

HeinzWuert opened this issue Feb 11, 2021 · 8 comments · Fixed by #3304
Labels
feature request good first issue good issue for your first time contribution
Milestone

Comments

@HeinzWuert
Copy link

Is your feature request related to a problem? Please describe.
Bookings with same start and stop time are making no sense, but are now possible

Describe the solution you'd like
Prevent these bookings.
If there is another sense behind this behavior make it optional via settings.

@kevinpapst
Copy link
Member

See also #2315

@HeinzWuert
Copy link
Author

to be closed

@kevinpapst
Copy link
Member

Nope, a discussion is not a feature request. I don't keep track of them.

@HeinzWuert
Copy link
Author

it's the same to #2315

@kevinpapst
Copy link
Member

Sorry for the confusion. I meant we keep this feature request, because a discussion will be gone soon.

@kevinpapst
Copy link
Member

kevinpapst commented Feb 19, 2021

TODO

  • Add a new system configuration
  • Add a new application configuration (active by default)
  • Add a new Constraint and Validator class:
    final class TimesheetZeroLength extends TimesheetConstraint see here, it will be automatically loaded and applied when saving a new record).

Problem might be: rounding rules could become a problem. They are applied later and we might not be able to detect if the given being and end datetime lead to an zero duration.

@HeinzWuert
Copy link
Author

My workaround in #2315 helps for the moment.

@kimai kimai deleted a comment from crm-developer May 15, 2021
@kevinpapst kevinpapst added good first issue good issue for your first time contribution and removed onboarding labels Mar 18, 2022
@kevinpapst kevinpapst added this to the 1.20 milestone May 17, 2022
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature request good first issue good issue for your first time contribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants