Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have the time entry box be modal #4867

Open
fulldecent opened this issue May 20, 2024 · 1 comment
Open

Have the time entry box be modal #4867

fulldecent opened this issue May 20, 2024 · 1 comment
Labels

Comments

@fulldecent
Copy link

Describe the problem

I tried watching several people on our team try Kimai for the first time. Several people had this problem:

When entering a time entry, they clicked outside the modal dialog. And the box closed. This required them to start over entering the time.

In one case, somebody misclicked below the "Save" button. They thought the time was recording but actually the time entry was stopped.

Describe the solution you'd like

When the modal dialog is open, if somebody clicks outside the modal dialog:

  1. Scroll to the action buttons
  2. Yellow flash the action buttons to indicate that they must be clicked.

Describe alternatives you've considered

No response

Screenshots

Screenshot 2024-05-20 at 11 44 04

@kevinpapst
Copy link
Member

kevinpapst commented May 20, 2024

When you change any field before clicking outside the modal, something like that already happens.
Its totally fine that the form closes if no value was changed.
But I am not sure why the duration field does not trigger the "isDirty" check on the form, I'll check.
Thanks for sharing!

@kevinpapst kevinpapst added this to the 2.18 milestone May 20, 2024
@kevinpapst kevinpapst removed this from the 2.18 milestone Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Planned
Development

No branches or pull requests

2 participants