Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove mobile navbar header #588

Closed
j0hannesr0th opened this issue Feb 20, 2019 · 5 comments
Closed

remove mobile navbar header #588

j0hannesr0th opened this issue Feb 20, 2019 · 5 comments
Labels
feature request plugin not meant to be implemented in the core, but could be a plugin
Milestone

Comments

@j0hannesr0th
Copy link
Contributor

Is your feature request related to a problem? Please describe.
At the moment Kimai - Time Tracking uses a lot of space on mobile views.

grafik

Describe the solution you'd like
"Home" should be added to the left menu swiper. Some margin/padding adjustments are needed, but it gives you more space on devices with a small screen.

grafik

@kevinpapst
Copy link
Member

Hey @hmr-it-jr, if you have the time and will to help testing?!

In #592 I added functionality for easy plugin loading.

I also created a first demo plugin, which adds the ability for custom css rules:
https://github.com/keleo/CustomCSSBundle

It comes with some pre-made rules, which can be added with a click of a button.
One of these rules is the necessary css to "remove header on mobile".

I'd appreciate if you could test that and let me know how it goes.

@j0hannesr0th
Copy link
Contributor Author

Hey @kevinpapst, of course I'll test it!

It's a pretty good idea to make it available with predefined rules and it works like a charm:
grafik

What do you think about adding a comment by default to the css if you use predifined rules? Or maybe add a font-awsome check icon to the rules which have been applied?

grafik

@kevinpapst
Copy link
Member

The comment sounds like a good improvement.
The icon instead could easily cause problems. When the user changes even one whitespace the detection could fail.

If you have further rules, which could be used by all users - they can very easily be added, they are basically only single css files:
https://github.com/Keleo/CustomCSSBundle/tree/master/Resources/ruleset

@kevinpapst kevinpapst added feature request plugin not meant to be implemented in the core, but could be a plugin labels Feb 23, 2019
@kevinpapst kevinpapst added this to the 0.9 milestone Feb 23, 2019
@kevinpapst
Copy link
Member

Done, closing

@lock
Copy link

lock bot commented Apr 25, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators Apr 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature request plugin not meant to be implemented in the core, but could be a plugin
Development

No branches or pull requests

2 participants