Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release code of complement layer #2

Closed
FENGGENYU opened this issue Sep 6, 2021 · 5 comments
Closed

Release code of complement layer #2

FENGGENYU opened this issue Sep 6, 2021 · 5 comments

Comments

@FENGGENYU
Copy link

Hi, I am interested in your work.

However, I find the first complement layer code is missing in your code model.py.

Will you plan to release the code of that part?

Looking forward to your reply, thank you!

Best.

@kimren227
Copy link
Owner

Hi Fenggen,

Thanks for your interest. I also came across your work "CAPRI-Net" a few months ago and found it very interesting.

As stated in the "Implementation Details" of the paper, adding a complement layer only increase the performance (quantitatively) slightly, however, with the cost of more computation, a larger learning space, leading to a longer and more unstable training process (sometimes, weird results are generated, see attached). Hence, the complement layer is not included in this version of the code.

I can make a new branch with the complement layer ASAP. Hopefully, that helps.

image
image

Best,

Daxuan

@FENGGENYU
Copy link
Author

Hi, Daxuan.

Thanks for your reply.

I am testing your model on ABC dataset, where I think the complement layer will be very helpful.

Looking forward to your new branch.

Best.

@kimren227
Copy link
Owner

Hi Fenggen,

I've created a new branch called "feature/with_complement". It should work, but I haven't thoroughly tested it yet.

Let me know if that solves your problem.

Best,

Daxuan

@kimren227
Copy link
Owner

Hi Fenggen,

I'll close this issue for now. If you got further questions, please reopen this issue.

Best,

Daxuan

@Farewell-ME
Copy link
Contributor

Hi, Daxuan.

Thanks for your reply.

I am testing your model on ABC dataset, where I think the complement layer will be very helpful.

Looking forward to your new branch.

Best.

hi, how is the performance on ABC dataset after complement layer is added?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants