Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do you use infinitely long cylinders and cones? #4

Closed
bluestyle97 opened this issue Dec 7, 2021 · 4 comments
Closed

Why do you use infinitely long cylinders and cones? #4

bluestyle97 opened this issue Dec 7, 2021 · 4 comments

Comments

@bluestyle97
Copy link

Hi, thanks for your excellent work! But I'm confused that why you use infinitely long cylinders and cones when computing the sdf. Why there is no "height" parameter associated with these two types of primitives? I think they need to be bounded to form the final shape. Could you please explain this for me? Thank you in advance!

@kimren227
Copy link
Owner

Hi Jiale,

Thanks for your interest.

There is no particular reason for infinitely long cylinders and cones. This is more a less a legacy issue (it is much easier to implement when cylinder and cone are unbounded). You are right, the individual cylinders and cones are not bounded shapes, but when intersecting with boxes or other types of primitives, the intersection result becomes bounded.

Hope this helps,

Daxuan

@bluestyle97
Copy link
Author

Thank you! I also notice that there is a sdfPlane function in sdfs.py but I didn't find it was used elsewhere. So I guess this function is useless for this project right?

@kimren227
Copy link
Owner

Yes, the sdfPlane is not used in the final project. It was implemented only for debug proposes.

@bluestyle97
Copy link
Author

Thanks for your kind explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants