Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Make AppVersion optional #40

Open
kinbiko opened this issue Oct 27, 2021 · 0 comments
Open

[Feature Request] Make AppVersion optional #40

kinbiko opened this issue Oct 27, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@kinbiko
Copy link
Owner

kinbiko commented Oct 27, 2021

What problem are you trying to solve?

Remove the need for the AppVersion config parameter from Go v1.18 onwards.
Go 1.18 will embed version information in the binary, and presumably a binary can know its own version.

Describe how you wish this package would help you solve the problem

Make AppVersion optional, and if missing attempt to read natively as part of the one-off data gathering when initialising a notifier. Only error when no AppVersion was provided and Go couldn't read it from the build information itself.

@kinbiko kinbiko added the enhancement New feature or request label Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

1 participant