Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add feature flag support #42

Open
7 tasks
kinbiko opened this issue Feb 11, 2022 · 0 comments
Open
7 tasks

[Feature Request] Add feature flag support #42

kinbiko opened this issue Feb 11, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@kinbiko
Copy link
Owner

kinbiko commented Feb 11, 2022

What problem are you trying to solve?

The error reporting API has now been updated to support feature flags, and there's no reason not to allow this feature via this package.

Announcement

Describe how you wish this package would help you solve the problem

Add a WithFeatureFlag(ctx context.Context, featureFlag, variant string) context.Context function to the notifier, and pass this information along in error reports.

  • WithFeatureFlag function in context.go
  • Update/Add unit tests in context_test.go
    • In particular, check intended behaviour (serialization for both error reports and Serialize/Deserialize)
  • Update integration test to include this feature.
  • Update examples
  • Add/update godocs
  • Update "Differences with the official notifier"
  • Release a new minor version

There does not seem to be a need to add this in sessions.

@kinbiko kinbiko added enhancement New feature or request good first issue Good for newcomers labels Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Todo
Development

No branches or pull requests

1 participant