-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLM.lua custom spell map commit broke midcast for nukes #14
Comments
Can you elaborate? sets.midcast.FastRecast should be the base layer for equipment selection, and anything else gets added on top of it (replacing whatever FastRecast had, if applicable). If you're not seeing more specific replacement gear, for which spells is that occurring, and what various modes (if not defaults)? Also, are you getting the info on what gear is being equipped from showswaps? |
My apologies for being vague. I'm actually trying to help a friend out, so it's a little awkward to test. He said no matter what elemental magic he cast, it was sticking him in sets.midcast.FastRecast. He was testing with both high tier and low teir spells. I added the get_nuke_class() function back, along with the following, in job_midcast, and it fixed it for him. if spell.skill == 'Elemental Magic' then I just assumed equipping sets.midcast.FastRecast wasn't allowing the custom class to be considered. If this is working for you, I'll have him download everything again and try again. Thanks |
You can close this. Somhow he was missing the job_get_spell_map function. Sorry to bother. |
Closing, per solved. |
job_midcast is ignoring the new spellMap functionality you built in.
i.e. sets.midcast.FastRecast is being used unconditionally.
Thanks!
The text was updated successfully, but these errors were encountered: