Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is the Adv360-Pro-GUI Repository not Public? #9

Closed
steinbrueckri opened this issue Sep 16, 2022 · 5 comments
Closed

Why is the Adv360-Pro-GUI Repository not Public? #9

steinbrueckri opened this issue Sep 16, 2022 · 5 comments

Comments

@steinbrueckri
Copy link

I ask because it is not possible to select "none" for a key in the Adv360-Pro-GUI. I love to contribute and create a PR but it's not possible. 馃槩
@KinesisCorporation
Copy link
Owner

Just toggled to public. Appreciate your contributions!

@steinbrueckri
Copy link
Author

@KinesisCorporation Thanks 馃檹

@steinbrueckri steinbrueckri closed this as not planned Won't fix, can't repro, duplicate, stale Sep 16, 2022
@steinbrueckri steinbrueckri reopened this Sep 17, 2022
@steinbrueckri
Copy link
Author

@KinesisCorporation After some research, it makes sense why "Adv360-Pro-GUI" was not public because it is just the build from the Vue App in the Repository https://github.com/KinesisCorporation/Adv360-Pro-KeymapEditor.

Correct me if I'm wrong but the KeyCodes are loaded from the Vue application from the adv360-pro-api. So I guess I cannot fix the issue by myself. 馃様

@Giljjj
Copy link

Giljjj commented Sep 17, 2022

image
Looks like &none is a behaviour (like &kp and &trans) and not a keycode.

@steinbrueckri
Copy link
Author

THX for the clarification I was not aware of that. @Giljjj @KinesisCorporation

jonatan-branting pushed a commit to jonatan-branting/Adv360-Pro-ZMK that referenced this issue Feb 1, 2024
@adv360proapp @jonatan-branting
# This is a combination of 16 commits.
1cbbfec 
# This is the 1st commit message:

Updated keymap
# The commit message KinesisCorporation#2 will be skipped:

# Updated keymap

# The commit message KinesisCorporation#3 will be skipped:

# feat: Add basic changes to make me feel more at home

# The commit message KinesisCorporation#4 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#5 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#6 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#7 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#8 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#9 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#10 will be skipped:

# Reduce brightness of leds

# The commit message KinesisCorporation#11 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#12 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#13 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#14 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#15 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#16 will be skipped:

# Updated adv360.keymap
duqcyxwd pushed a commit to duqcyxwd/Adv360-Pro-ZMK that referenced this issue May 17, 2024
@tobiaspickel
Merge pull request KinesisCorporation#9 from sanderdrummer/3.1
4c69437 
3.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@steinbrueckri @Giljjj @KinesisCorporation