Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for data-original with srcset #59

Closed
migueldemoura opened this issue Mar 8, 2018 · 2 comments
Closed

Support for data-original with srcset #59

migueldemoura opened this issue Mar 8, 2018 · 2 comments

Comments

@migueldemoura
Copy link
Collaborator

migueldemoura commented Mar 8, 2018 •
edited

Hey, pretty cool project!

I noticed that the data-original functionality doesn't work with img's srcset. Replacing the image's src doesn't change the image since srcset takes precedence. This is usually used for responsive images.

Edit: just noticed this commit 717b997, which isn't included in the latest version.
Closing this issue.
@migueldemoura
Copy link
Collaborator Author

Could you push a new minor version with this fix? @kingdido999

@kingdido999
Copy link
Owner

Done. The fix is in 1.4.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kingdido999 @migueldemoura