Support favorites nodes

[markiewb]

Currently it is not possible to open a console for the selected root-node in the favorites window. The action is not enabled.

EXPECTED: Support datashadow
Taken from my own plugin:

    private FileObject getFileObjectWithShadowSupport(DataObject dataObject) {
        if (dataObject instanceof DataShadow) {
            DataShadow dataShadow = (DataShadow) dataObject;
            return dataShadow.getOriginal().getPrimaryFile();
        }
        return dataObject.getPrimaryFile();
    }

[dzsessona]

Hi markiewb. Your code works fine, but there is a problem: the action is enabled with the cookie DataObject. At the moment i believe you can enable disable the action choosing one of:

-) Project
-) Open cookie
-) EditCookie
-) EditorCookie
-) DataObject

So the action in that case would be disabled. One thing i have done though is the following: you can open favourite root folders by using the "open terminal (or filesystem) in" ... action. I know there are a few more clicks but I think it could work, Here is a screenshot of what i have done, tell me what you think. Or if you know how to write a custom action enabler....

[markiewb]

Or if you know how to write a custom action enabler....

Alternative a) Use a CookieAction

• See http://netbeans.dzone.com/news/which-netbeans-platform-action . Especially the section "Deprecated? Not Quite"
• See http://benkiew.wordpress.com/2013/01/06/netbeans-ide-7-3-how-to-extend-the-context-menu-of-the-members-and-hierarchy-view/ (see enabled() and cookieClasses())

Alternative b) Extend from AbstractAction

• See http://benkiew.wordpress.com/2012/12/28/netbeans-how-to-create-a-context-aware-action-with-an-icon-for-the-context-menu/ (within isEnabled() you can check for whatever you want. For example: Check for FileObj, then for DataObject, then fallback to other things)

I know this will be some refactoring within your code, but afterwards it is more flexible then. I hope that will help you.

[markiewb]

Do you need any support?

[dzsessona]

Hi markieweb, thank you! Well, if you want, i cannot find not even 5 minutes to work on it. Hopefully next week i will not be so busy.

[markiewb]

@kinkadzs : Any news here?

[markiewb]

@kinkadzs : How about merging my pull request? Did you managed to review the patch? A new version for the plugin center would be very nice.

[dzsessona]

@markiewb i did review it but still for 7.3 friday 25 october will be done for 7.4 and will publish the plugin! :-)

[markiewb]

@kinkadzs Thank you!

[dzsessona]

working on it now....

[dzsessona]

@markiewb hi, i have just uploaded the 7.4 version, I merged your pull request but the root of favorites nodes still have the actions disabled... do you mind having a quick look at it? Now i should be able to work on this plugin a bit more btw.... And thanks, I mentioned you on netbeans center.

[markiewb]

@kinkadzs I will have a look within the next days. IIRC my patched worked times ago. I will figure it out and provide a new pull request if neccessary

[dzsessona]

@markiewb That's great! Thanks

[markiewb]

@kinkadzs : Please review #30 (reference)
The actions now work for favorite root nodes too, but I now the toolbar icons are gone. Can you figure that out?

[dzsessona]

cool, will check that on the weekend.

[markiewb]

Fixed in 1.1.0

It was easier than I originally thought