Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subdomains & boundaries in refinement #104

Closed
2 of 5 tasks
kinnala opened this issue Nov 24, 2018 · 5 comments
Closed
2 of 5 tasks

Subdomains & boundaries in refinement #104

kinnala opened this issue Nov 24, 2018 · 5 comments
Milestone

Comments

@kinnala
Copy link
Owner

kinnala commented Nov 24, 2018

The subdomains and boundaries are currently invalid if one refines the mesh. Create a method to Mesh which removes them on refine and override in MeshTri etc. to create new indexing

Boundaries:

  • MeshTri uniform
  • MeshTri adaptive
  • MeshQuad
  • MeshTet
  • MeshHex
@gdmcbain
Copy link
Contributor

gdmcbain commented Nov 24, 2018

This would be perfect for the empirical convergence study of #13; thus far I've been remeshing the Gmsh GEO from scratch.

@gdmcbain
Copy link
Contributor

Yes, and this would be even more comvenient in conjunction with the adaptive use of Mesh.refine demonstrated in #80.

@kinnala
Copy link
Owner Author

kinnala commented Nov 24, 2018

For now I added a warning that the indexing is invalidated.

Subdomains are simple to maintain in refine, but now that I thought about this more carefully I think that maintaining the named boundaries is very hard using the current data structures. There are many edge cases so you have to be very careful or do something clever.

@kinnala
Copy link
Owner Author

kinnala commented Nov 25, 2018

Uniform refine in MeshTri now should preserve named boundaries (stuff in Mesh.boundaries) in ec297c1. I was overly pessimistic in the previous comment: it was quite straightforward although it required some meditation.

@kinnala
Copy link
Owner Author

kinnala commented Nov 25, 2018

I realized that there is still a bug in refine when called with integer larger than one. This is just a reminder for myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants