Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facet assembly and MappingIsoparametric #22

Closed
kinnala opened this issue Jul 29, 2018 · 3 comments
Closed

Facet assembly and MappingIsoparametric #22

kinnala opened this issue Jul 29, 2018 · 3 comments

Comments

@kinnala
Copy link
Owner

kinnala commented Jul 29, 2018

Because I never was a great user of quad/hex elements, the boundary mapping -related parts of MappingIsoparametric do not exist. This means that facet assembly does not currently work at all with quads and hexes.

Fixing this issue requires writing tests and implementing the remaining methods in MappingIsoparametric.

Note that this was already implemented in the Python 2.7 version of the code: https://github.com/kinnala/sp.fem/blob/master/spfem/mapping.py#L173. This gives lots of hints but I hope the new version would use np.einsum like the other mapping methods.

Update 28.11.2018: Write more tests and this can be closed.

@kinnala kinnala added this to the 0.2.0 milestone Jul 30, 2018
@kinnala
Copy link
Owner Author

kinnala commented Aug 12, 2018

Quadrilateral boundary assembly is now at least partially working in 77bd5fc. Getting the indexing correctly for hexahedral elements is harder than I anticipated and requires more work. MappingIsoparametric.normals is just a stub implementation so that the current version can be tested.

@kinnala
Copy link
Owner Author

kinnala commented Aug 12, 2018

It seems that the indexing was correct. In the inverse isoparametric mapping you need a numerical method at each quadrature point since the mapping cannot be inverted analytically. It turned out that I had a stupid initial guess, origin of the reference system. In 2D this worked fine (Quads) but in 3D the Jacobian determinant at origin seems to be zero. More tests are required before this issue is closed though.

@kinnala
Copy link
Owner Author

kinnala commented Sep 22, 2018

Also, normal vector implementation is missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant