How to get a system theme with ThemeManager?

[denik7770]

tbsys.Text = ModernWpf.ThemeManager.GetActualTheme(this).ToString();
This does not return me an actual theme, it returns a requested theme, but if there isno requested theme, then it returns default.

[denik7770]

As you see, a theme is not actually light.

[Kinnara]

In theory, your code should work and GetActualTheme should always return either Light or Dark but never Default, otherwise there is a bug. Anyway, what it returns doesn't matter much unless you're using more advanced features like defining/overriding theme resources at the element level.

Without seeing the code it can be hard to tell what exactly went wrong in your case. One issue I see is that both ModernWPF and FluentWPF are trying to set the window style (through attached property) and only one will take effect. For the moment I believe using the FluentWPF style would be simpler. The resources in App.xaml also need to be set up in a certain way to get the two libraries work together without conflicts. I made a sample app available here to demonstrate the setup.

[denik7770]

Thank you reaally much for your answer and support!!😊😊

[ashelleyPurdue]

Slightly off topic, but what would be the purpose behind using both FluentWPF and ModernWpf? I thought ModernWpf was, more or less, a replacement for FluentWPF.

Is it so your app can make use of the acrylic effect?

[denik7770]

I think, that to make an acrylic effect, the best way is by using FluentWPF.

[denik7770]

In theory, your code should work and GetActualTheme should always return either Light or Dark but never Default, otherwise there is a bug. Anyway, what it returns doesn't matter much unless you're using more advanced features like defining/overriding theme resources at the element level.

Without seeing the code it can be hard to tell what exactly went wrong in your case. One issue I see is that both ModernWPF and FluentWPF are trying to set the window style (through attached property) and only one will take effect. For the moment I believe using the FluentWPF style would be simpler. The resources in App.xaml also need to be set up in a certain way to get the two libraries work together without conflicts. I made a sample app available here to demonstrate the setup.

I'm still getting this issue, but at least, they do not conflict with themes.

[Kinnara]

Ah, now I see you want the app to use the Windows theme mode. Simply adding a proper app manifest should enable that. This commit 84f4069 shows how to do that. Basically you add an app manifest to your project and uncomment the Windows 10 line.

If your app still doesn't pick up the Windows theme (don't forget to remove any RequestedTheme) I also made some changes that should make system theme handling more robust. It's not published on NuGet yet but you can clone the latest code and try the FluentWPF sample.

[ShankarBUS]

Hey @Kinnara, Since the requirement for app.manifest is now optional, apps will now follows system themes without any additional requirements.

The OP's problem was, they couldn't fetch system theme because they didn't have the manifest and didn't know it was required.

Can this issue be closed now?

[Kinnara]

Yes, I believe so. Thanks for the reminder.