Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delete records command #230

Merged
merged 16 commits into from
Feb 21, 2023
Merged

feat: delete records command #230

merged 16 commits into from
Feb 21, 2023

Conversation

hung-cybo
Copy link
Contributor

@hung-cybo hung-cybo commented Feb 16, 2023

Why

As cli-kintone v0.X.X, It has -D option. With this option, the user can delete all records inside the App before importing.
Now, with cli-kintone v1.0, we also support the delete records command, so that the user can delete all/delete specified records before importing new records.

  • cli-kintone v0.X.X
    Execute import command with -D option ( delete records → add records )
  • cli-kintone v1.0
    1: Execute the delete records command
    2: Execute import command

What

  • [] The delete all records command is added, e.g. cli-kintone record delete
  • [] The delete specified records command is added, e.g. cli-kintone record delete --file-path path_to_csv_file.csv

How to test

yarn build & yarn test

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed yarn lint and yarn test on the root directory.

@hung-cybo hung-cybo requested review from a team and tasshi-me and removed request for a team February 16, 2023 02:48
Copy link
Member

@tasshi-me tasshi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job!

hung-cybo and others added 2 commits February 18, 2023 16:33
Co-authored-by: tasshi / Masaharu TASHIRO <33759872+mshrtsr@users.noreply.github.com>
@tasshi-me tasshi-me merged commit aaaf4b0 into main Feb 21, 2023
@tasshi-me tasshi-me deleted the feat/delete-records-command branch February 21, 2023 02:01
This was referenced Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants