Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show version correctly #250

Merged
merged 1 commit into from
Feb 27, 2023
Merged

fix: show version correctly #250

merged 1 commit into from
Feb 27, 2023

Conversation

tasshi-me
Copy link
Member

@tasshi-me tasshi-me commented Feb 27, 2023

Why

From v1.3.0, the --version doesn't work correctly.
Since we started building with Vite, the reference to package.json has disappeared, and package.json is no longer bundled with the executable.

What

  • show version correctly on cli-kintone --version command

How to test

yarn install
yarn build

./bin/cli-kintone-macos --version

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed yarn lint and yarn test on the root directory.

@tasshi-me tasshi-me requested review from a team and ueokande and removed request for a team February 27, 2023 05:22
Copy link
Member

@ueokande ueokande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works, thank you!

@ueokande ueokande merged commit da92cad into main Feb 27, 2023
@ueokande ueokande deleted the fix/show-version-correctly branch February 27, 2023 05:44
This was referenced Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants