Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable record import with a Record Number field #368

Merged
merged 5 commits into from
Jun 9, 2023

Conversation

tasshi-me
Copy link
Member

@tasshi-me tasshi-me commented Jun 7, 2023

Why

Currently, importing (add/upsert) records with a Record Number field fails.
On GUI CSV import, a Record Number field in CSV is ignored and importing is performed successfully.

What

  1. Remove a Record Number field from records when upserting

How to test

Using CSV that includes a Record Number field

"recordNumber",uniqueKey,"text"
"1","record1","existing data 1"
"2","record2","existing data 2"
"3","record3","new data"

Execute import command

## upsert: The Record number field is ignored, and importing finishes successfully
node  ./cli.js record import --app $APP_ID --file-path ./records.csv --update-key uniqueKey

## add: The Record number field is still evaluated and causes an error
node ./cli.js record import --app $APP_ID --file-path ./records.csv

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed yarn lint and yarn test on the root directory.

@tasshi-me tasshi-me force-pushed the feat/can-upsert-with-record-number-field branch from e26fed5 to 57e2b3c Compare June 7, 2023 11:13
@tasshi-me tasshi-me marked this pull request as ready for review June 8, 2023 09:55
@tasshi-me tasshi-me requested review from a team and hung-cybo and removed request for a team June 8, 2023 09:55
Copy link
Member

@ueokande ueokande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🎋

@tasshi-me tasshi-me requested a review from ueokande June 9, 2023 09:05
Copy link
Contributor

@hung-cybo hung-cybo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hung-cybo hung-cybo merged commit ae4846e into main Jun 9, 2023
10 checks passed
@hung-cybo hung-cybo deleted the feat/can-upsert-with-record-number-field branch June 9, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants