Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tf.signal is differentiable #22

Closed
rryan opened this issue Dec 30, 2019 · 6 comments
Closed

tf.signal is differentiable #22

rryan opened this issue Dec 30, 2019 · 6 comments

Comments

@rryan
Copy link

rryan commented Dec 30, 2019

Hi there,

I'm the author of Tensorflow's tf.signal package. Your paper says that tf.signal does not support gradients, however this is not true. All operations in tf.signal are fully differentiable and come with GPU and TPU support. Could you please update your paper on arXiv to correct this?

@rryan
Copy link
Author

rryan commented Dec 30, 2019

I think you were trying to say that it does not support a trainable basis? That's true, but it's still differentiable so you can incorporate it into a network and backpropagate through it (e.g. to add a spectral loss to model that generates time-domain waveforms -- as in Parallel WaveNet)

@rryan
Copy link
Author

rryan commented Dec 30, 2019

Nice job on this repo and the paper by the way :).

@KinWaiCheuk
Copy link
Owner

I think you were trying to say that it does not support a trainable basis? That's true, but it's still differentiable so you can incorporate it into a network and backpropagate through it (e.g. to add a spectral loss to model that generates time-domain waveforms -- as in Parallel WaveNet)

Thanks for pointing it out. You are right, I was talking about the trainable basis. I will fix the paper now.

@KinWaiCheuk
Copy link
Owner

Hi Ryan, I have removed the claim that tf.signal doesn't support backpropagation.
Can you check if it is better now?
https://arxiv.org/abs/1912.12055

@rryan
Copy link
Author

rryan commented Jan 4, 2020

Thanks a lot for updating it!

@rryan rryan closed this as completed Jan 4, 2020
@antonwnk
Copy link

antonwnk commented May 4, 2020

Hi. Can I ask what is meant by trainable basis?
I came across this issue while googling around to see whether I could optimize tf.signal.stft's frame_length and frame_step parameters along with all the other parameters of my network, through backprop. Would this be technically possible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants