Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong currency returned #17

Closed
jschlyter opened this issue Feb 9, 2021 · 4 comments
Closed

Wrong currency returned #17

jschlyter opened this issue Feb 9, 2021 · 4 comments

Comments

@jschlyter
Copy link
Contributor

jschlyter commented Feb 9, 2021

The Nordpool API will return all answers in EUR unless an area is specified at the same time. This currently results in multiple issues. Since the library selects currency first (elspot.Prices) and area second (hourly), the currency will always be returned in EUR (the most common one).

This can be replicated via the Nordpool web UI:

Further investigation shows that the pages defined at https://github.com/kipe/nordpool/blob/master/nordpool/elspot.py#L11 does not provide data in other currencies than EUR. Using specific pages (e.g., 29 for SE3) returns data in multiple currencies. The area to page map is most likely subject to change of course.

@jschlyter
Copy link
Contributor Author

Draft fix implemented in #20. Requires code changes since you can no longer fetch data for areas in multiple countries, see example in PR.

@kipe
Copy link
Owner

kipe commented Feb 12, 2021

Hmm, actually seems like Nordpool has fixed this?
Can @jschlyter confirm, at least I'm unable to replicate the issue currently.

@jschlyter
Copy link
Contributor Author

Hmm, actually seems like Nordpool has fixed this?
Can @jschlyter confirm, at least I'm unable to replicate the issue currently.

I concur! Seems to work as before now.

@kipe
Copy link
Owner

kipe commented Feb 12, 2021

Then I think we'll close both this and #20 for now, but let me know if this re-occurs and we'll get back on it.
I'll do a new release with the exception now, so at least it's easier to catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants