This repository has been archived by the owner on Sep 1, 2022. It is now read-only.
Add Write endpoint for Courses #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkagin
force-pushed
the
write_new_courses
branch
2 times, most recently
from
068bc30
to
fb49f44
Compare
zkagin
force-pushed
the
identify_changes_to_be_made
branch
from
6de3816
to
836d36a
Compare
zkagin
force-pushed
the
write_new_courses
branch
from
fb49f44
to
138fd56
Compare
dchess
reviewed
Oct 8, 2020
|
@zkagin Can you rebase or resolve the merge conflicts? |
zkagin
force-pushed
the
write_new_courses
branch
from
138fd56
to
074d575
Compare
zkagin
force-pushed
the
write_new_courses
branch
from
074d575
to
fcaa936
Compare
|
@dchess Ready for your review. |
dchess
approved these changes
Dec 16, 2020
|
@zkagin This looks good to me. I'm going look through the other related PRs. How should I proceed? Should I merge each into this one and then merge to main or is it worth rebasing each as we go? |
|
@dchess Great! I generally like to merge them one-by-one, mostly because merging one giant PR makes me nervous, and this allows us to more easily squash and then preserve commits. Everything has been rebased right now and should merge cleanly, but whenever you merge I'll go ahead and rebase each one to update it as well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #98
Fixes #86
Adds the first sync endpoint, for Courses. Note that this doesn't handle errors or batching, which will come in the next PR so that the code can be shared with the existing batching code.
A few things are renamed to match the endpoint more accurately.